Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-22 Thread Gary Gregory
My +1 Gary On Wed, Mar 20, 2019 at 10:26 PM Gary Gregory wrote: > We have fixed quite a few bugs and added some significant enhancements > since Apache Commons BCEL 6.3 was released, so I would like to release > Apache Commons BCEL 6.3.1. > > Apache Commons BCEL 6.3.1 RC1 is available for revie

Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-21 Thread Rob Tompkins
+1, build works on java 8 and 10, site good, signatures good, rat good..some nits low coverage and we could improve the checkstyle/pmd and such. > On Mar 21, 2019, at 4:07 AM, Bruno P. Kinoshita > wrote: > > [ X ] +1 Release these artifacts > > > Build passing with `mvn clean test install

Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-21 Thread Gary Gregory
Thank you for the review Alex. Feel free to provide PRs :-) Gary On Thu, Mar 21, 2019 at 9:44 AM Alex Herbert wrote: > +1 (non-binding) > > (Note: A few Spotbugs errors should be addressed/looked at soon, see > below). > > > > mvn -v > Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f

Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-21 Thread Alex Herbert
+1 (non-binding) (Note: A few Spotbugs errors should be addressed/looked at soon, see below). mvn -v Apache Maven 3.6.0 (97c98ec64a1fdfee7767ce5ffb20918da4f719f3; 2018-10-24T19:41:47+01:00) Maven home: /usr/local/apache-maven-3.6.0 Java version: 1.8.0_191, vendor: Oracle Corporation, runtime

Re: [VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-21 Thread Bruno P. Kinoshita
  [ X ] +1 Release these artifacts Build passing with `mvn clean test install site` on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00)Maven home: /opt/apache-maven-3.5.4Java version: 1.8.0_191, vendor: Oracle Corporation, runtime: /usr/lib/jvm/java-8-

[VOTE] Release Apache Commons BCEL 6.3.1 based on RC1

2019-03-20 Thread Gary Gregory
We have fixed quite a few bugs and added some significant enhancements since Apache Commons BCEL 6.3 was released, so I would like to release Apache Commons BCEL 6.3.1. Apache Commons BCEL 6.3.1 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/bcel/6.3.1-RC1 (sv