[RESULT][VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-28 Thread Simone Tripodi
Hi all guys, Since 72 hours passed I'm declaring this vote as closed and passed with 3 positive votes from PMCs: * Simone Tripodi * Luc Maisonobe * Oliver Heger no other votes were cast. I'll move the proposed release to dist/ and give 24 hours for mirrors to sync before making ANN and site u

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-27 Thread Simone Tripodi
Hi Gary!! I tried to force the PMD plugin to version 2.5 in the Digester pom.xml, unfortunately looking at the effective pom I realized that the site-plugin-3.0 continues using the pmd-plugin-2.3, because it is configured inside the reportset :( I'll have a deep look at the site-plugin. Thanks for

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Gary Gregory
Simo, I'm on my phone ATM so I cannot check this, but are you using the latest versions of the plugins? Maybe some of these false positives would go away. Gary On Oct 25, 2011, at 17:39, Simone Tripodi wrote: > Hi Gary! > > That is the same I wondered: if 6 are "too many", how many are enough?

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Oliver Heger
Build works fine with Java 1.5 on Windows 7. Artifacts and site look good. The checkstyle issue really is not a blocker. So +1, good work! Oliver Am 25.10.2011 22:10, schrieb Simone Tripodi: Hi all guys, I'm writing to call for a vote to release apache commons-digester-3.1 based on RC2. This

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Simone Tripodi
Thanks for reviewing Oliver :) Just to avoid mistakes, I already fixed it so for next RCs there won't be mistakes anymore :P Alles gute! Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Oct 26, 20

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Oliver Heger
Am 26.10.2011 09:42, schrieb Simone Tripodi: [X] +1 release it There is one glitch, but not blocking: the checkstyle-suppressions.xml file is not included in the source distribution (it is not in the /src/main/assembly/src.xml configuration file), so when rebuilding from the source archive tri

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Simone Tripodi
>> >> [X] +1 release it > > There is one glitch, but not blocking: the checkstyle-suppressions.xml > file is not included in the source distribution (it is not in the > /src/main/assembly/src.xml configuration file), so when rebuilding from > the source archive triggers many checkstyle errors in th

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Luc Maisonobe
Le 25/10/2011 22:10, Simone Tripodi a écrit : > Hi all guys, > I'm writing to call for a vote to release apache commons-digester-3.1 > based on RC2. > > This is the 3.1RC1 release with fixed doubts were raise in the first VOTE > call. > Please take in consideration that broken 3.1 links will be f

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Simone Tripodi
Bonjour Luc! yes it is the binary folder[1] :) Thanks a lot in advance for reviewing, have anice day! Simo [1] http://people.apache.org/builds/commons/digester/3.1/RC2/binaries/ http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-26 Thread Luc Maisonobe
Le 26/10/2011 08:55, Luc Maisonobe a écrit : > Le 25/10/2011 22:10, Simone Tripodi a écrit : >> Hi all guys, >> I'm writing to call for a vote to release apache commons-digester-3.1 >> based on RC2. > > I may not be completely awake yet but where are the source tar and zip > archives and their sig

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Luc Maisonobe
Le 25/10/2011 22:10, Simone Tripodi a écrit : > Hi all guys, > I'm writing to call for a vote to release apache commons-digester-3.1 > based on RC2. I may not be completely awake yet but where are the source tar and zip archives and their signatures ? Luc > > This is the 3.1RC1 release with fix

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Simone Tripodi
this is my explicit +1 http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Wed, Oct 26, 2011 at 12:01 AM, Simone Tripodi wrote: > Thanks for the hints David, really appreciated!! > all the best, > Simo > > ht

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Simone Tripodi
Thanks for the hints David, really appreciated!! all the best, Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Tue, Oct 25, 2011 at 11:46 PM, David Karlsen wrote: > You can use http://pmd.sourceforge

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread David Karlsen
You can use http://pmd.sourceforge.net/suppressing.html for suppression of edge-cases like empty catch blocks. The first one is simply a false one (e.g. pmd bug). 2011/10/25 Simone Tripodi : > Hi Gary! > > That is the same I wondered: if 6 are "too many", how many are enough? :) > Maybe it's time

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Simone Tripodi
Hi Gary! That is the same I wondered: if 6 are "too many", how many are enough? :) Maybe it's time PMD updates its rules? :P About the other PMD violations: `Avoid unused private methods such as 'npeSafeCast(Object)'` is not true, it is used: 2624 public T peek() 2625 { 2626 tr

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Gary Gregory
Hi Simo, Not blockers but the PMD issues could be addressed except: Should we turn off "Too many static imports may lead to messy code"? How many is too many? Gary On Tue, Oct 25, 2011 at 4:10 PM, Simone Tripodi wrote: > Hi all guys, > I'm writing to call for a vote to release apache commons-d

[VOTE] Release Apache Commons-Digester 3.1 based on RC2

2011-10-25 Thread Simone Tripodi
Hi all guys, I'm writing to call for a vote to release apache commons-digester-3.1 based on RC2. This is the 3.1RC1 release with fixed doubts were raise in the first VOTE call. Please take in consideration that broken 3.1 links will be fixed once the site will be deployed. The vote will stay open