Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-24 Thread Simone Tripodi
Hallo Oliver, All's well that ends well :) Nice to see you finally got the expected results! Thanks for reviewing, I'll push a new RC in a short while! All the best, alles gute! Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi htt

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-24 Thread Oliver Heger
Am 23.10.2011 22:43, schrieb Phil Steitz: On 10/23/11 12:42 PM, Oliver Heger wrote: Am 23.10.2011 20:16, schrieb Simone Tripodi: Hi Oliver!! I now realize that the checkstyle plugin is not smart as we expect :) I guess you launched `mvn checkstyle:checkstyle`, if you do a `svn up&& mv

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Simone Tripodi
Hi Phil! thanks for reporting, links are indeed broken - I just fixed them. Thanks, have a nice day! Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Oct 23, 2011 at 10:43 PM, Phil Steitz wrote:

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread James Carman
I believe it's... mvn -X Sent from tablet device. Please excuse typos and brevity. On Oct 23, 2011 4:43 PM, "Phil Steitz" wrote: > On 10/23/11 12:42 PM, Oliver Heger wrote: > > Am 23.10.2011 20:16, schrieb Simone Tripodi: > >> Hi Oliver!! > >> I now realize that the checkstyle plugin is not sm

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Phil Steitz
On 10/23/11 12:42 PM, Oliver Heger wrote: > Am 23.10.2011 20:16, schrieb Simone Tripodi: >> Hi Oliver!! >> I now realize that the checkstyle plugin is not smart as we >> expect :) >> >> I guess you launched `mvn checkstyle:checkstyle`, if you do a >> >> `svn up&& mvn clean site&& open target

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Oliver Heger
Am 23.10.2011 20:16, schrieb Simone Tripodi: Hi Oliver!! I now realize that the checkstyle plugin is not smart as we expect :) I guess you launched `mvn checkstyle:checkstyle`, if you do a `svn up&& mvn clean site&& open target/site/checkstyle.html` you can see totally different result!

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Simone Tripodi
Hi Oliver!! I now realize that the checkstyle plugin is not smart as we expect :) I guess you launched `mvn checkstyle:checkstyle`, if you do a `svn up && mvn clean site && open target/site/checkstyle.html` you can see totally different result!!! Please let me know, many thanks in advance! A

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Oliver Heger
Am 23.10.2011 18:37, schrieb Simone Tripodi: Nice hint, thanks Phil!!! all the best, Simo It's really strange. I locally changed the digester pom to use version 2.7 of checkstyle, but again I see the same errors. I uploaded checkstyle.html to [1] so you can have a look at the output. Are th

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Simone Tripodi
Nice hint, thanks Phil!!! all the best, Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Sun, Oct 23, 2011 at 6:10 PM, Phil Steitz wrote: > On 10/22/11 8:02 AM, Oliver Heger wrote: >> Am 21.10.2011 23

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Phil Steitz
On 10/22/11 8:02 AM, Oliver Heger wrote: > Am 21.10.2011 23:19, schrieb Simone Tripodi: >> Forgot to mention about checkstyle: no idea. If you built the >> Digester >> using the provided pom, there shouldn't be ambiguity... any hint? > > Being no maven guru, I haven't got a clue either. I also woul

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Simone Tripodi
Hi again Oliver, I just ran `mvn clean site && open target/site/checkstyle.html` using Java5 and got the following checkstyle report: Files Infos WarningsErrors 165 0 0 0 that's what I get executing `mvn --version` $ mvn --version Apache Maven 3.0.3 (r1075438; 2011-02

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-23 Thread Simone Tripodi
Hallo Oliver! sorry for the late reply, I just executed the same command and that's the checkstyle config I got: maven-checkstyle-plugin 2.6 config/maven_checks.xml config/maven-header.txt /Users/simonetripodi/Documents/workspace/commo

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-22 Thread Oliver Heger
Am 21.10.2011 23:19, schrieb Simone Tripodi: Forgot to mention about checkstyle: no idea. If you built the Digester using the provided pom, there shouldn't be ambiguity... any hint? Being no maven guru, I haven't got a clue either. I also would expect that the pom contains sufficient informati

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-21 Thread Simone Tripodi
Forgot to mention about checkstyle: no idea. If you built the Digester using the provided pom, there shouldn't be ambiguity... any hint? TIA!!! Simo http://people.apache.org/~simonetripodi/ http://simonetripodi.livejournal.com/ http://twitter.com/simonetripodi http://www.99soft.org/ On Fri, Oct

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-21 Thread Simone Tripodi
Hi Oliver, thanks for the deep review!! I think that under a legal point of view - NOTICE file is included in the artifact - it would be better give another RC and take advantage to fix also PMD violations. Let's wait anyway for the end of the vote and see how thing go, in the meanwhile I fix wha

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-21 Thread Oliver Heger
Build works fine with Java 1.5 on Windows 7. Artifacts look good. I found the following problems: - The Copyright in NOTICE.txt says still 2010. - The release notes claim to be for version 3.0 in the header. - There are some PMD errors which could be addressed (not blocking). - A bit strange: Whe

Re: [VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-20 Thread sebb
On 19 October 2011 22:38, Simone Tripodi wrote: > Hi all guys, > I'm writing to call for a vote to release apache commons-digester-3.1 > based on RC1. > > This is the 3.0 release with the new async feature - not very much but > enough to justify a new release. > Please take in consideration that b

[VOTE] Release Apache Commons-Digester 3.1 based on RC1

2011-10-19 Thread Simone Tripodi
Hi all guys, I'm writing to call for a vote to release apache commons-digester-3.1 based on RC1. This is the 3.0 release with the new async feature - not very much but enough to justify a new release. Please take in consideration that broken 3.1 links will be fixed once the site will be deployed.