Re: [VOTE] DBCP 2.2 rc2

2017-03-07 Thread Gary Gregory
On Mar 8, 2017 5:37 AM, "Matt Sicker" wrote: It's been a few months now, oh wow! I'll be working on making a commons-pool release later this week. After that, I'll update commons-dbcp to use the new release and create rc3 for this. I don't have access to the project where I was able to reproduce

Re: [VOTE] DBCP 2.2 rc2

2017-03-07 Thread Matt Sicker
It's been a few months now, oh wow! I'll be working on making a commons-pool release later this week. After that, I'll update commons-dbcp to use the new release and create rc3 for this. I don't have access to the project where I was able to reproduce the OSGi issues anymore (old employer), so it'

Re: [VOTE] DBCP 2.2 rc2

2016-10-31 Thread Stian Soiland-Reyes
Here's an approach we used in Jena with partial success: https://github.com/apache/jena/tree/master/apache-jena-osgi/jena-osgi-test Uses PaxExam - https://ops4j1.jira.com/wiki/display/paxexam/Pax+Exam On 31 October 2016 at 15:22, Matt Sicker wrote: > Oh, yes, rc2 is cancelled. I forgot to clea

Re: [VOTE] DBCP 2.2 rc2

2016-10-31 Thread Matt Sicker
Oh, yes, rc2 is cancelled. I forgot to clean up. And yes, help is appreciated. I haven't had a chance to look back at this, but one of the things we wanted to accomplish with this bug fix was to also introduce a pattern for black box testing Commons libraries in OSGi. On 31 October 2016 at 10:15,

Re: [VOTE] DBCP 2.2 rc2

2016-10-31 Thread Stian Soiland-Reyes
Hi, Matt, Was this DBCP Release Candidate vote cancelled..? I noticed it is still in https://repository.apache.org/content/repositories/orgapachecommons-1196/ https://dist.apache.org/repos/dist/dev/commons/dbcp/DBCP_2_2_RC2/ BTW - do you need some help with https://issues.apache.org/jira/browse

Re: [VOTE] DBCP 2.2 rc2

2016-08-09 Thread Gary Gregory
On Tue, Aug 9, 2016 at 8:27 AM, Matt Sicker wrote: > Yes, I'd like to make a decent integration test for this. This could have > helped the original bugfix that caused this new bug, too. :) > Yes, that's worth doing. Too bad it will delay DBCP, but there is a nice upshot with a new reusable inte

Re: [VOTE] DBCP 2.2 rc2

2016-08-09 Thread Matt Sicker
Yes, I'd like to make a decent integration test for this. This could have helped the original bugfix that caused this new bug, too. :) On 9 August 2016 at 10:23, Gary Gregory wrote: > This is more than likely something all Commons components could benefit > from... I would be really nice to capt

Re: [VOTE] DBCP 2.2 rc2

2016-08-09 Thread Gary Gregory
This is more than likely something all Commons components could benefit from... I would be really nice to capture your testing in an integration test we can run from Maven. We could put anything generic in a Commons OSGi component even if it only has test code. Gary On Mon, Aug 8, 2016 at 10:17

Re: [VOTE] DBCP 2.2 rc2

2016-08-08 Thread Matt Sicker
Damn, I'm still having OSGi issues with this RC. I've reopened https://issues.apache.org/jira/browse/DBCP-454 to investigate. I may need to cut an rc3, though. On 7 August 2016 at 14:03, Matt Sicker wrote: > We have fixed quite a few bugs and added some significant enhancements > since DBCP 2.1.

[VOTE] DBCP 2.2 rc2

2016-08-07 Thread Matt Sicker
We have fixed quite a few bugs and added some significant enhancements since DBCP 2.1.1 was released, so I would like to release DBCP 2.2. Changes since 2.2 rc1: * Added a bug fix from jira that wasn't included in the release notes as it had the wrong fix version attached. * Fixed DBCP-454. * Fixe