Re: [VOTE] Apache Commons Daemon 1.2.4 based on RC1

2021-01-10 Thread Mark Thomas
I'm going to vote -1 on RC1 as I forgot to sign the Windows binaries. I'll fix the issues Bruno notes below and then roll an RC2. Mark On 08/01/2021 03:42, Bruno P. Kinoshita wrote: >   [x] +1 Release these artifacts > > NB: the NOTICE file needs the yearly update, from 2020 to 2021. Not a blo

Re: [VOTE] Apache Commons Daemon 1.2.4 based on RC1

2021-01-07 Thread Bruno P. Kinoshita
  [x] +1 Release these artifacts NB: the NOTICE file needs the yearly update, from 2020 to 2021. Not a blocker I think? Building OK from tag with `mvn clean test install site` on Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe; 2018-06-18T06:33:14+12:00) Maven home: /opt/apache

Re: [VOTE] Apache Commons Daemon 1.2.4 based on RC1

2021-01-07 Thread Gary Gregory
+1 Based on the src zip testing on Windows 10 with Oracle Java 8 and Maven 3.6.3. Apache RAT check OK. Apache CLIRR check OK. Site builds OK but does not show the Clirr report (or JApiCmp which we now use instead). Windows natives build OK. Using: - Microsoft Windows [Version 10.0.19041.685] -

[VOTE] Apache Commons Daemon 1.2.4 based on RC1

2021-01-06 Thread Mark Thomas
We have fixed a few bugs including a regression since Apache Commons Daemon 1.2.3 was released, so I would like to release Apache Commons Daemon 1.2.4. Apache Commons Daemon 1.2.4 RC1 is available for review here: https://dist.apache.org/repos/dist/dev/commons/daemon/1.2.4-RC1 (svn revision 45203)