Re: [TEXT] Review of the code base

2015-04-29 Thread Benedikt Ritter
gt; >>>> No problem, thanks for pushing this forward. >> >>>> >> >>>> Here are some more things we need to take care of before 1.0: >> >>>> - JIRA project >> >>>> >> >>> Requested a JIRA project: >> >>&

Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
t;>>> > >>>>> Thanks again for reviewing the code! > >>>>> > >>>> No problem, thanks for pushing this forward. > >>>> > >>>> Here are some more things we need to take care of before 1.0: > >>>>

Re: [TEXT] Review of the code base

2015-04-26 Thread Phil Steitz
handle this after we have merged the changes made to the names package. >>>> >>>> >>>>> Thanks again for reviewing the code! >>>>> >>>> No problem, thanks for pushing this forward. >>>> >>>> Here are some

Re: [TEXT] Review of the code base

2015-04-26 Thread Bruno P. Kinoshita
t, justify), Burrows–Wheeler transform, etc. But I think prior to a 1.0 release, TEXT-16 is the only pending issue. What do you think? CheersBruno From: Benedikt Ritter To: Commons Developers List Sent: Sunday, April 26, 2015 10:14 PM Subject: Re: [TEXT] Review of the code base

Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
>> >>> Here are some more things we need to take care of before 1.0: >>> - JIRA project >>> >> >> Requested a JIRA project: >> https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9477 >> > > Here is the JIRA project [

Re: [TEXT] Review of the code base

2015-04-26 Thread Benedikt Ritter
gt;>> Thanks again for reviewing the code! >>> >> >> No problem, thanks for pushing this forward. >> >> Here are some more things we need to take care of before 1.0: >> - JIRA project >> > > Requested a JIRA project: > https://issues.ap

Re: [TEXT] Review of the code base

2015-04-19 Thread Benedikt Ritter
;> >> >>> Thanks again for reviewing the code! >>> >> >> No problem, thanks for pushing this forward. >> >> Here are some more things we need to take care of before 1.0: >> - JIRA project >> > > Requested a JIRA project: > https://issues.apache

Re: [TEXT] Review of the code base

2015-04-19 Thread Benedikt Ritter
d. > > Here are some more things we need to take care of before 1.0: > - JIRA project > Requested a JIRA project: https://issues.apache.org/jira/servicedesk/customer/portal/1/INFRA-9477 > - Rename similarity package to distance package? We have five Distance > implementations but onl

Re: [TEXT] Review of the code base

2015-04-19 Thread Benedikt Ritter
similarity package to distance package? We have five Distance implementations but only one Similarity. Furthermore we have FuzzyScore. Is it a distance or a similarity? It should be renamed accordingly. - ConsineSimilariy uses Vectors modeled as Map. Does it make sense to introduce a new class calle

Re: [TEXT] Review of the code base

2015-04-19 Thread Bruno P. Kinoshita
;& ! "".equals($VAR)` instead? Thanks again for reviewing the code! All the best,Bruno From: Benedikt Ritter To: Commons Developers List Sent: Sunday, April 19, 2015 9:01 PM Subject: [TEXT] Review of the code base Hi all, I've looked through the code base of

[TEXT] Review of the code base

2015-04-19 Thread Benedikt Ritter
Hi all, I've looked through the code base of [text] and I already did some clean up. However there are a few things, that need more work IMHO: 1. IP clearance! There are several comments talking about code adapted from PHP libraries. This needs to be listed in NOTICE.txt. For an example see the N