Re: [RDF] adding Quads - Bulk

2024-03-10 Thread Peter Hull
I don't know much about RDF4J but my comments would be 1. Better IMO to add a default method to the interface rather than adding 11 implementations which are almost identical 2. No need to restrict it to a List when any iterable would do 3. There is a bulk 'add' method in RepositoryConnection (http

Re: [RDF] adding Quads - Bulk

2024-03-10 Thread Fred Hauschel
Ah, sorry. i forgot to post this PR here: https://github.com/apache/commons-rdf/pull/205 I did it right after the mail. Thanks Fredy On 10.03.24 13:42, Peter Hull wrote: On Sat, 9 Mar 2024 at 22:37, Fred Hauschel wrote: Is there a reason, why there is no Method like GraphLike#add(List state

Re: [RDF] adding Quads - Bulk

2024-03-10 Thread Peter Hull
On Sat, 9 Mar 2024 at 22:37, Fred Hauschel wrote: > Is there a reason, why there is no Method like GraphLike#add(List > statements); ? It would be possible to add a method with a default implementation to GraphLike - then look to see if this can be more efficient for RDF4J (e.g. avoiding the mul

[RDF] adding Quads - Bulk

2024-03-09 Thread Fred Hauschel
Hi there, it looks like I am bound to the interface org.apache.commons.rdf.api.GraphLike#add. And in the RDF4J implementation, a new connection to the repository is established for each quad/triple. This is not very useful. Am I missing another possibility or am I the first to have a problem