Indifferent. Though, I personally like forcing as much of the build/validation
into the developer’s machine in a default way as possible. :-p
-Rob
> On Aug 3, 2020, at 9:51 AM, Gary Gregory wrote:
>
> I think it is also fine to not force feed it in a component's Maven
> lifecycle as long as it
I think it is also fine to not force feed it in a component's Maven
lifecycle as long as it is listed in the defaultGoal element for that POM.
Maybe that would make a POM slightly less unwieldy.
Gary
On Mon, Aug 3, 2020 at 9:37 AM sebb wrote:
> RAT is currently run during the validate phase, w
RAT is currently run during the validate phase, which is very early in
the cycle.
I think that is a nuisance, as it gets in the way of local testing.
Any new file has to have an AL header, or you have to remember to use
-Drat.skip.
This makes it harder to use test cases, e.g. provided in bug repor
+1
Am 10.08.2019 um 16:42 schrieb Gary Gregory:
Hi all,
It seems to me the commons-parent should cause the RAT check to run for all
builds, say in the... validate phase?
Gary
-
To unsubscribe, e-mail: dev-unsubscr...@commo
On Sat, 10 Aug 2019 at 15:42, Gary Gregory wrote:
>
> Hi all,
>
> It seems to me the commons-parent should cause the RAT check to run for all
> builds, say in the... validate phase?
I think that might quickly become annoying; the verify phase might be better.
> Gary
Hi all,
It seems to me the commons-parent should cause the RAT check to run for all
builds, say in the... validate phase?
Gary
Maybe put it in a profile, and you can document that that profile will be
used to check _and_ run that profile for the travis builds, such that a
failed travis build will show that the pr is invalid.
On March 12, 2019 at 09:39:44, Gary Gregory (garydgreg...@gmail.com) wrote:
On Mon, Mar 11, 2019
On Mon, Mar 11, 2019 at 4:59 PM Jochen Wiedmann
wrote:
> On Mon, Mar 11, 2019 at 5:58 PM Gary Gregory
> wrote:
>
> > The idea, for me, is that a contributor should not be able to test and
> > submit a PR with a failing RAT check.
>
> If so, then I'd suggest a server-side Git hook for that.
>
I
On Mon, Mar 11, 2019 at 5:58 PM Gary Gregory wrote:
> The idea, for me, is that a contributor should not be able to test and
> submit a PR with a failing RAT check.
If so, then I'd suggest a server-side Git hook for that.
Jochen
-
On Mon, Mar 11, 2019 at 6:58 AM Jochen Wiedmann
wrote:
> On Sat, Mar 9, 2019 at 11:45 PM Gary Gregory
> wrote:
>
> > How about making apache-rat:check run automatically in commons-parent? In
> > the Maven validate phase?
>
> Not being a Maven expert: When would that check run, exactly? If that
>
On Mon, Mar 11, 2019 at 6:58 AM Jochen Wiedmann
wrote:
> On Sat, Mar 9, 2019 at 11:45 PM Gary Gregory
> wrote:
>
> > How about making apache-rat:check run automatically in commons-parent? In
> > the Maven validate phase?
>
> Not being a Maven expert: When would that check run, exactly? If that
>
On Sat, Mar 9, 2019 at 11:45 PM Gary Gregory wrote:
> How about making apache-rat:check run automatically in commons-parent? In
> the Maven validate phase?
Not being a Maven expert: When would that check run, exactly? If that
would include a simple "mvn clean install", then I'd definitely be -1,
+1 to anything that makes releasing easier.
Am Sa., 9. März 2019 um 23:45 Uhr schrieb Gary Gregory <
garydgreg...@gmail.com>:
> Hi all:
>
> How about making apache-rat:check run automatically in commons-parent? In
> the Maven validate phase?
>
> That would mean one less thing to check when integr
Running in verify is OK as well.
Gary
On Sun, Mar 10, 2019, 06:35 sebb OK, but please provide a property to switch it off on the command-line.
>
> I think it is going to be very annoying for local development,
> especially if it runs at such an early phase.
>
> It could also be done in a much la
OK, but please provide a property to switch it off on the command-line.
I think it is going to be very annoying for local development,
especially if it runs at such an early phase.
It could also be done in a much later phase, e.g. verify
That would certainly be sufficient for RC creation.
On Sun
+1
Am 09.03.2019 um 23:44 schrieb Gary Gregory:
Hi all:
How about making apache-rat:check run automatically in commons-parent? In
the Maven validate phase?
That would mean one less thing to check when integrating a patch and
validating an RC.
Gary
-
(please make sure to CC me on replies)
+1
On Sat, 9 Mar 2019 at 19:51, Bruno P. Kinoshita wrote:
>
>
>
> Also cannot think of a reason why not. So +1
>
>
>
>
> On Sunday, 10 March 2019, 2:06:05 pm NZDT, Rob Tompkins
> wrote:
>
>
>
>
>
>
>
> > On Mar 9, 2019, at 7:40 PM, Gilles Sadowski wrote:
Also cannot think of a reason why not. So +1
On Sunday, 10 March 2019, 2:06:05 pm NZDT, Rob Tompkins
wrote:
> On Mar 9, 2019, at 7:40 PM, Gilles Sadowski wrote:
>
>> Le sam. 9 mars 2019 à 23:45, Gary Gregory a écrit :
>>
>> Hi all:
>>
>> How about making apache-rat:check run a
> On Mar 9, 2019, at 7:40 PM, Gilles Sadowski wrote:
>
>> Le sam. 9 mars 2019 à 23:45, Gary Gregory a écrit :
>>
>> Hi all:
>>
>> How about making apache-rat:check run automatically in commons-parent? In
>> the Maven validate phase?
>>
>> That would mean one less thing to check when integr
Le sam. 9 mars 2019 à 23:45, Gary Gregory a écrit :
>
> Hi all:
>
> How about making apache-rat:check run automatically in commons-parent? In
> the Maven validate phase?
>
> That would mean one less thing to check when integrating a patch and
> validating an RC.
+1
[Why not?]
Gilles
>
> Gary
Hi all:
How about making apache-rat:check run automatically in commons-parent? In
the Maven validate phase?
That would mean one less thing to check when integrating a patch and
validating an RC.
Gary
21 matches
Mail list logo
