Re: [Numbers] NUMBERS-33

2017-05-10 Thread Raymond DeCampo
On Wed, May 10, 2017 at 10:49 AM, Gilles wrote: > Hi. > > > On Tue, 9 May 2017 12:59:40 -0400, Raymond DeCampo wrote: > >> If I make the method static and rename it to "gamma", then I can do the >>> >> much >> >>> simpler: >>> Stream d = numbers.parallelStream().map(Gamma::gamma); >>> >> >> I

Re: [Numbers] NUMBERS-33

2017-05-10 Thread Gilles
Hi. On Tue, 9 May 2017 12:59:40 -0400, Raymond DeCampo wrote: If I make the method static and rename it to "gamma", then I can do the much simpler: Stream d = numbers.parallelStream().map(Gamma::gamma); It seems to me like the above, suggested by Stian earlier if I am not mistaken, is th

Re: [Numbers] NUMBERS-33

2017-05-09 Thread Raymond DeCampo
> If I make the method static and rename it to "gamma", then I can do the much > simpler: > Stream d = numbers.parallelStream().map(Gamma::gamma); It seems to me like the above, suggested by Stian earlier if I am not mistaken, is the best option of the ones you have discussed, once you agree o

Re: [Numbers] NUMBERS-33

2017-05-09 Thread Stian Soiland-Reyes
On Tue, 09 May 2017 14:52:09 +0200, Gilles wrote: > [I specifically avoided "apply" so that it is free for when the > component > targets Java 8.] > > Can the "apply" method be static? No, interface implementations can't be static (and it is not possible to make an interface of static methods).

Re: [Numbers] NUMBERS-33

2017-05-09 Thread Stian Soiland-Reyes
On Tue, 9 May 2017 13:29:21 +0100, Stian Soiland-Reyes wrote: > I can only see this "value()" style make sense if there is also a common > interface, perhaps DoubleFunction? > https://docs.oracle.com/javase/8/docs/api/java/util/function/DoubleFunction.html DoubleUnaryOperator would be better - do

Re: [Numbers] NUMBERS-33

2017-05-09 Thread Gilles
Hi. On Tue, 9 May 2017 13:29:21 +0100, Stian Soiland-Reyes wrote: On Mon, 08 May 2017 14:16:12 +0200, Gilles wrote: > Overall the addition looks good and well commented. The javadoc is a > bit > sparse and could do with some more hyperlinks. Strange; I thought that it was doing rather well on

Re: [Numbers] NUMBERS-33

2017-05-09 Thread Stian Soiland-Reyes
On Mon, 08 May 2017 14:16:12 +0200, Gilles wrote: > > Overall the addition looks good and well commented. The javadoc is a > > bit > > sparse and could do with some more hyperlinks. > Strange; I thought that it was doing rather well on this point. > Can you be more specific? [Please open a JIRA r

Re: [Numbers] NUMBERS-33

2017-05-08 Thread Gilles
Hello Stian. On Mon, 8 May 2017 10:01:48 +0100, Stian Soiland-Reyes wrote: Thanks! Thanks for taking the time to review. :-) Not being a mathematician I am afraid I have not been able to review the correctness of the equation use. I didn't either; I assumed to be correctness as per year

Re: [Numbers] NUMBERS-33

2017-05-08 Thread Stian Soiland-Reyes
Thanks! Not being a mathematician I am afraid I have not been able to review the correctness of the equation use. Overall the addition looks good and well commented. The javadoc is a bit sparse and could do with some more hyperlinks. I have some code design questions you may be able to clarify:

[Numbers] NUMBERS-33

2017-05-07 Thread Gilles
Hi. Please review branch "task_NUMBERS-33__Gamma": https://issues.apache.org/jira/browse/NUMBERS-33 Thanks, Gilles - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@common