Re: [EXTERNAL] [Numbers][All] Separate Java target version for "src/test"

2021-06-14 Thread Ralph Goers
I don’t understand this. Log4j2 was one of the first adopters of multi-release jars. There were problems in the beginning but those have virtually all been resolved. We haven’t had any complaints in ages. Log4j 2 2.14.1 supports Java 8. Fully supporting JPMS (i.e. - adding a module-info.java

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-14 Thread Gilles Sadowski
Hello. Le lun. 14 juin 2021 à 00:37, John Patrick a écrit : > > So I want to start using Java 11 and take advantage of Java Modules. But > with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, > and most dependencies I want to upgrade eventually get stuck on a commons > projec

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-13 Thread sebb
On Sun, 13 Jun 2021 at 23:37, John Patrick wrote: > > So I want to start using Java 11 and take advantage of Java Modules. But > with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, > and most dependencies I want to upgrade eventually get stuck on a commons > project holding a

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-13 Thread John Patrick
So I want to start using Java 11 and take advantage of Java Modules. But with a bug in Java Multi-Jar not supporting 1.8 as base and 11 upon that, and most dependencies I want to upgrade eventually get stuck on a commons project holding a pure JPMS solution. Potentially someone raise an enhancemen

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-10 Thread Gilles Sadowski
Le jeu. 10 juin 2021 à 14:42, John Patrick a écrit : > > If the tests are valid and useful once post Java 1.8, what about > starting the next release branch where the min version bumps to Java > 11. [Numbers] and related components were meant to replace and improve some functionalities provided i

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-10 Thread John Patrick
If the tests are valid and useful once post Java 1.8, what about starting the next release branch where the min version bumps to Java 11. As Java 17 starting ramp down starts today I believe so in 3 months we will have 3 LTS (1.8, 11 and 17) releases. So technically Java 18 development starts tomor

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-10 Thread Gilles Sadowski
Le jeu. 10 juin 2021 à 13:05, sebb a écrit : > > Thanks. > > I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) AFAIK, this is an auto-generated file (from changes.xml). Gilles > > On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > > > I have removed the requirement fo

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-10 Thread sebb
Thanks. I've updated the RELEASE-NOTES accordingly (feel free to tweak the text) On Thu, 10 Jun 2021 at 00:58, Alex Herbert wrote: > > I have removed the requirement for Java 9 from the build. It is still used > in the performance testing module. > > Alex ---

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
I have removed the requirement for Java 9 from the build. It is still used in the performance testing module. Alex

Re: [EXTERNAL] Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Strauss, Randy (ARC-TI)[KBR Wyle Services, LLC]
Note that the test could inspect the java version, or use reflection to see if the method BigDecimal.sqrt() exists... -r Randy Strauss, cell: 650-861-1537 On 6/9/21, 2:57 PM, "sebb" wrote: On Wed, 9 Jun 2021 at 19:58, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:56, sebb wrote

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread sebb
On Wed, 9 Jun 2021 at 19:58, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:56, sebb wrote: > > > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > > wrote: > > > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > > wrote: > > > > > > > Have you tried "9" instead of "1.9"? > > > > > > > > > > I've c

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Gilles Sadowski
Le mer. 9 juin 2021 à 20:58, Alex Herbert a écrit : > > On Wed, 9 Jun 2021 at 17:56, sebb wrote: > > > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > > wrote: > > > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > > wrote: > > > > > > > Have you tried "9" instead of "1.9"? > > > > > > > > > > I'v

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 17:56, sebb wrote: > On Wed, 9 Jun 2021 at 17:26, Alex Herbert > wrote: > > > > On Wed, 9 Jun 2021 at 17:03, John Patrick > wrote: > > > > > Have you tried "9" instead of "1.9"? > > > > > > > I've corrected that in the pom, thanks. > > > > I think the issue is that Gilles

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread sebb
On Wed, 9 Jun 2021 at 17:26, Alex Herbert wrote: > > On Wed, 9 Jun 2021 at 17:03, John Patrick wrote: > > > Have you tried "9" instead of "1.9"? > > > > I've corrected that in the pom, thanks. > > I think the issue is that Gilles used JDK 8 to try and build it. You can > run using the project's m

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Alex Herbert
On Wed, 9 Jun 2021 at 17:03, John Patrick wrote: > Have you tried "9" instead of "1.9"? > I've corrected that in the pom, thanks. I think the issue is that Gilles used JDK 8 to try and build it. You can run using the project's main artifacts using JDK 8, but the build now requires JDK 9 for the

Re: [Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread John Patrick
Have you tried "9" instead of "1.9"? I believe the 1.x was dropped with Java 9's release. Also might want to bump it to Java 11 as that is a LTS release, as 9 was only supported for 6 months from september 2017 to march 2018. Also with 9 and newer, maven.compiler.source/maven.compiler.target have

[Numbers][All] Separate Java target version for "src/test"

2021-06-09 Thread Gilles Sadowski
Hi. "Commons Numbers" POM of module "commons-numbers-core" contains ---CUT--- 1.9 1.9 ---CUT--- Running $ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/ mvn test site site:stage fails: ---CUT--- [...] [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.8.1:t