Re: [Math] Please review GA implementation

2022-01-24 Thread Avijit Basak
Hi All I have taken all changes from the feature branch and put my code for commons-math-ga and examples-ga modules. A new PR(#204) is also created and the previous PR(#203) is closed. Thanks & Regards --Avijit Basak On Sat, 22 Jan 2022 at 23:02, Gilles Sadowski wrote: > Le sam. 22 jan

Re: [Math] Please review GA implementation

2022-01-22 Thread Gilles Sadowski
Le sam. 22 janv. 2022 à 15:30, Avijit Basak a écrit : > > Hi > > >Please be sure to use my latest (forced) update. > >[I removed the many duplicate commits I had introduced by mistake.] > > --Is the change only in commons-math-examples/pom.xml file? Please confirm. No, there can be other commits,

Re: [Math] Please review GA implementation

2022-01-22 Thread Avijit Basak
Hi >Please be sure to use my latest (forced) update. >[I removed the many duplicate commits I had introduced by mistake.] --Is the change only in commons-math-examples/pom.xml file? Please confirm. My changes are creating conflict after this push. I shall create a new PR. Thanks & Regards --Avij

Re: [Math] Please review GA implementation

2022-01-20 Thread Gilles Sadowski
Hi. Le jeu. 20 janv. 2022 à 17:58, Gilles Sadowski a écrit : > > Hello. > > Le jeu. 20 janv. 2022 à 13:09, Avijit Basak a écrit : > > > > Hi All > > > >I have restructured the examples-ga module to fix a few issues and > > created separate child modules for each type of usages. There was

Re: [Math] Please review GA implementation

2022-01-20 Thread Gilles Sadowski
Hello. Le jeu. 20 janv. 2022 à 13:09, Avijit Basak a écrit : > > Hi All > >I have restructured the examples-ga module to fix a few issues and > created separate child modules for each type of usages. There was also a > minor bug related to the logger class name in commons-ga module, which

Re: [Math] Please review GA implementation

2022-01-20 Thread Avijit Basak
Hi All I have restructured the examples-ga module to fix a few issues and created separate child modules for each type of usages. There was also a minor bug related to the logger class name in commons-ga module, which I fixed. A new PR(*#203*) has been created. Kindly review the same and l

Re: [Math] Please review GA implementation

2022-01-12 Thread Avijit Basak
Hi All I have lost track of the jar creation process in the examples module. Everytime before commiting I have executed examples using Eclipse IDE which ran successfully. I need to modify the examples module. Sorry for any inconvenience. Please find my additional responses below. >There a

Re: [Math] Please review GA implementation

2022-01-08 Thread Gilles Sadowski
Hello. I've also started to take a look. There are issues with the expected functionality of the "examples-ga" module. Assuming that the following command has been issued $ JAVA_HOME=/usr/lib/jvm/java-8-openjdk-amd64/ mvn package and has completed successfully, executable JAR files should have

Re: [Math] Please review GA implementation

2022-01-08 Thread Avijit Basak
Hi All I would like to add a few words over here. The JIRA was initially created as a proposal to accommodate rank based adaptive probability generation approaches for GA operators like crossover and mutation etc following the referred article. The article mainly describes the adaptive pro

Re: [Math] Please review GA implementation

2022-01-08 Thread Bruno P. Kinoshita
Reviewed about 1/4 of the PR, but it was mainly about serialization (started from the bottom, comparing using GitHub UI [1]). But that code and tests were looking OK. Will try to go over a few more files, but I also found a PDF in the issue that I think I will try to read first, to have a bet

[Math] Please review GA implementation

2022-01-03 Thread Gilles Sadowski
Hello. I've just created a "feature__MATH-1563__genetic_algorithm" branch[1] in the git repository, with the code provided by Avijit Basak in PR #200, a proposed replacement of the "o.a.c.math4.legacy.genetics" package.[2] Reviews welcome. Regards, Gilles [1] https://gitbox.apache.org/repos/asf