Hi.
Le dim. 7 juin 2020 à 15:07, Gilles Sadowski a écrit :
>
> [...]
>
> The current flood of email messages from GitHub is not sustainable
> for me (sorry).
I'm not registered on GitHub; hence even when I agree with your
proposed changes (e.g. PR #152), I cannot comment directly over
there.
In
Hi.
Le dim. 7 juin 2020 à 12:54, Xeno Amess a écrit :
>
> Ahhh you are right.
> I'm new to JIRA. sory
I'll take the opportunity to draw your attention to pending issues in
"Commons Math"[1] that would prevent releasing the next version.
It's great that you want to clean up the codebase, but
Ahhh you are right.
I'm new to JIRA. sory
Gilles Sadowski 于2020年6月7日周日 下午6:50写道：
> Hi.
>
> 2020-06-07 8:21 UTC+02:00, Xeno Amess :
> > If you are telling about 144:
> > yes, original codes runs like:
> > f[0] = f0;
> > f[1] = f1;
> > f[2] = f[2-2] = f[0] = f[0]
> > f[3] = f[3-2] = f[1] = f[1
Hi.
2020-06-07 8:21 UTC+02:00, Xeno Amess :
> If you are telling about 144:
> yes, original codes runs like:
> f[0] = f0;
> f[1] = f1;
> f[2] = f[2-2] = f[0] = f[0]
> f[3] = f[3-2] = f[1] = f[1]
> f[4] = f[4-2] = f[2] = f[0]
> f[5] = f[5-2] = f[3] = f[1]
>
> the new codes runs like:
> f[0] = f0;
>
If you are telling about 144:
yes, original codes runs like:
f[0] = f0;
f[1] = f1;
f[2] = f[2-2] = f[0] = f[0]
f[3] = f[3-2] = f[1] = f[1]
f[4] = f[4-2] = f[2] = f[0]
f[5] = f[5-2] = f[3] = f[1]
the new codes runs like:
f[0] = f0;
f[1] = f1;
f[2] = 2&1==0 ? f0 : f1 = f0
f[3] = 3&1==0 ? f0 : f1 = f
Hi.
2020-06-06 14:21 UTC+02:00, Xeno Amess :
> Alright, done.
> This pr is now splitted into two prs.
> https://github.com/apache/commons-math/pull/144
> https://github.com/apache/commons-math/pull/143
I think that there are issues with some of the changes (e.g. where
the previous code used an "i
Hello.
2020-06-06 13:47 UTC+02:00, Xeno Amess :
> Yes you are right.
>>you must squash the commits.
>>the commit messages are uninformative
>
> Usually I'd do them when commiter think this pr is ok,
As said before, it's needlessly difficult to figure out the
net changes when they result from seve
Alright, done.
This pr is now splitted into two prs.
https://github.com/apache/commons-math/pull/144
https://github.com/apache/commons-math/pull/143
Thx.
Xeno Amess 于2020年6月6日周六 下午7:47写道：
> Yes you are right.
> >you must squash the commits.
> >the commit messages are uninformative
>
> Usually
Yes you are right.
>you must squash the commits.
>the commit messages are uninformative
Usually I'd do them when commiter think this pr is ok, and then tell me we
should merge it, and at that moment I squash it, and it get merged.
the commit messages will be fixed at that time too.
>partly revert
Hi.
2020-06-06 10:18 UTC+02:00, GitBox :
>
> XenoAmess opened a new pull request #143:
> URL: https://github.com/apache/commons-math/pull/143
>
>
>use System.arraycopy instead of loop.
>
There are several issues with this PR.
It contains several commits, among which some seem,
IIUC, to partl
10 matches
Mail list logo
