Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Hank Grabowski
OK. If you want to put the "trivial modifications" that are required so the code is "on par with what we had usually committed as new contributions" in the JIRA incident, I can try to address them this week as well. On Mon, Oct 20, 2014 at 5:51 PM, Gilles wrote: > On Mon, 20 Oct 2014 19:33:25 +

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Gilles
On Mon, 20 Oct 2014 19:33:25 +0200, Luc Maisonobe wrote: Le 20/10/2014 16:00, Hank Grabowski a écrit : I have some time this week to try to get these changes made to the interpolators. I don't want to do anything without consensus however. So to try to incorporate the discussion above plus a

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Luc Maisonobe
Le 20/10/2014 16:00, Hank Grabowski a écrit : > I have some time this week to try to get these changes made to the > interpolators. I don't want to do anything without consensus however. So > to try to incorporate the discussion above plus a concerned raised over the > weekend on the JIRA thread

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-20 Thread Hank Grabowski
I have some time this week to try to get these changes made to the interpolators. I don't want to do anything without consensus however. So to try to incorporate the discussion above plus a concerned raised over the weekend on the JIRA thread I propose: 1. Adding the original functionality back

Re: [Math] Disagreeing about how MATH-1138 has been handled

2014-10-17 Thread Gilles
Hi Hank. On Fri, 17 Oct 2014 11:31:26 -0400, Hank Grabowski wrote: Gilles, This is the original changes to get the bicubic spline working. These were originally committed as a diff that was attached to the JIRA incident. The suggestions in your email were in response to my questions about w

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Hank Grabowski
I didn't want to address the situation in my original response since I was on a smart phone, a bit torqued up by the original e-mail and I didn't want to further agitate the situation by addressing the original implementation. Since it seems that's all happened anyway, if you still want my newbie

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Luc Maisonobe
Hi all, Le 17/10/2014 16:23, Gilles a écrit : > Hi. > > On Fri, 17 Oct 2014 10:46:53 +0200, Luc Maisonobe wrote: >> Hi Hank, >> >> Le 16/10/2014 20:20, Hank Grabowski a écrit : >>> OK. I submitted the pull request yesterday. I'm going to now remove >>> the >>> diff from JIRA. >>> >>> https://gi

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Phil Steitz
Lets calm down, guys. As Luc said, we are experimenting here, getting the git workflow established. No one is trying to exclude or discourage anyone. Hank or Luc, can you respond to Gilles' questions about the commit? If not, it should be reverted, but hopefully you can all three agree on a way

Re: [Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Hank Grabowski
Gilles, This is the original changes to get the bicubic spline working. These were originally committed as a diff that was attached to the JIRA incident. The suggestions in your email were in response to my questions about work carrying forward from that point. I have been very explicit and verb

[Math] Disagreeing about how MATH-1138 has been handled (Was: [math] GitHub vs ASF Repo)

2014-10-17 Thread Gilles
Hi. On Fri, 17 Oct 2014 10:46:53 +0200, Luc Maisonobe wrote: Hi Hank, Le 16/10/2014 20:20, Hank Grabowski a écrit : OK. I submitted the pull request yesterday. I'm going to now remove the diff from JIRA. https://github.com/apache/commons-math/pull/2 Thank you. I have merged this request