Re: [Math] Code review

2010-10-02 Thread Phil Steitz
On 10/2/10 3:25 PM, Ted Dunning wrote: Another option is to have a small community of activists who are willing to comb the code and improve it without requiring everybody to catch all these issues. If what you mean by this is that we don't expect committers to fix checkstyle / findbugs error

Re: [Math] Code review

2010-10-02 Thread Ted Dunning
Another option is to have a small community of activists who are willing to comb the code and improve it without requiring everybody to catch all these issues. On Sat, Oct 2, 2010 at 8:37 AM, Phil Steitz wrote: > From my perspective, checkstyle.xml effectively represents our coding style > rules

Re: [Math] Code review

2010-10-02 Thread Phil Steitz
On 10/1/10 5:23 PM, Gilles Sadowski wrote: On Fri, Oct 01, 2010 at 04:05:11PM -0500, Brent Worden wrote: On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski wrote: Do you review the code manually, or do you use a tool to spot all these potential problems? Eclipse reports these, and I inspect th

Re: [Math] Code review

2010-10-01 Thread Ted Dunning
On Fri, Oct 1, 2010 at 3:22 PM, sebb wrote: > On 1 October 2010 22:54, Ted Dunning wrote: > > In Mahout, we have found that IntelliJ (which is usually like Eclipse, > but > > more thorough) does not warn on the same things > > that findbugs, pmd or checkstyle warn on. We haven't been able to fo

Re: [Math] Code review

2010-10-01 Thread sebb
On 1 October 2010 22:54, Ted Dunning wrote: > In Mahout, we have found that IntelliJ (which is usually like Eclipse, but > more thorough) does not warn on the same things > that findbugs, pmd or checkstyle warn on.  We haven't been able to force > that behavior very well, either.  That means that

Re: [Math] Code review

2010-10-01 Thread Ted Dunning
In Mahout, we have found that IntelliJ (which is usually like Eclipse, but more thorough) does not warn on the same things that findbugs, pmd or checkstyle warn on. We haven't been able to force that behavior very well, either. That means that we have to use a combination of methods to drive down

Re: [Math] Code review

2010-10-01 Thread Gilles Sadowski
On Fri, Oct 01, 2010 at 04:05:11PM -0500, Brent Worden wrote: > On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski > wrote: > >> > Do you review the code manually, or do you use a tool to spot all these > >> > potential problems? > >> > >> Eclipse reports these, and I inspect them manually before com

Re: [Math] Code review

2010-10-01 Thread Brent Worden
On Fri, Oct 1, 2010 at 9:27 AM, Gilles Sadowski wrote: >> > Do you review the code manually, or do you use a tool to spot all these >> > potential problems? >> >> Eclipse reports these, and I inspect them manually before committing. > > Isn't there some plugin such as CheckStyle or FindBugs that c

Re: [Math] Code review

2010-10-01 Thread Gilles Sadowski
> > Do you review the code manually, or do you use a tool to spot all these > > potential problems? > > Eclipse reports these, and I inspect them manually before committing. Isn't there some plugin such as CheckStyle or FindBugs that could be called from maven? Gilles -

Re: [Math] Code review (Was: Re: svn commit: r1003533 - ...)

2010-10-01 Thread sebb
On 1 October 2010 14:49, Gilles Sadowski wrote: > Hi. > >> URL: http://svn.apache.org/viewvc?rev=1003533&view=rev >> Log: >> Unnecessary cast >> >> [...] > > Do you review the code manually, or do you use a tool to spot all these > potential problems? Eclipse reports these, and I inspect them man

[Math] Code review (Was: Re: svn commit: r1003533 - ...)

2010-10-01 Thread Gilles Sadowski
Hi. > URL: http://svn.apache.org/viewvc?rev=1003533&view=rev > Log: > Unnecessary cast > > [...] Do you review the code manually, or do you use a tool to spot all these potential problems? Regards, Gilles - To unsubscribe, e-