Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-17 Thread Xeno Amess
Oh so animal-sniffer is the plugin we use to check this kind of issue? Thanks, I will learn about it later. Mark Thomas 于2020年8月17日周一 下午3:58写道: > On 16/08/2020 16:45, Xeno Amess wrote: > >> I've pushed change to the pom which allows compilation on Java14. > > > > Well it might be silly to ask bu

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-17 Thread Mark Thomas
On 16/08/2020 16:45, Xeno Amess wrote: >> I've pushed change to the pom which allows compilation on Java14. > > Well it might be silly to ask but, is there a mechanism for us to make sure > that openjdk 6 output jar of this repo can be run totally correct on newer > JVM s? As per the email you re

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Jochen Wiedmann
On Sun, Aug 16, 2020 at 12:13 PM Xeno Amess wrote: > 2. we wait for user argue about this. Mark Thomas just did, no need to wait. :-) -- Look, that's why there's rules, understand? So that you think before you break 'em. -- (Terry Pratchett, Thief of Time)

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Xeno Amess
> I've pushed change to the pom which allows compilation on Java14. Well it might be silly to ask but, is there a mechanism for us to make sure that openjdk 6 output jar of this repo can be run totally correct on newer JVM s? sebb 于2020年8月16日周日 下午11:37写道: > I've also updated LOGGING to build o

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread sebb
I've also updated LOGGING to build on Java12+ The animal-sniffer signature should catch incompatible changes. AFAICT there is therefore no need to change the minimum version merely to make CI easier. On Sun, 16 Aug 2020 at 16:05, Mark Thomas wrote: > > On 16/08/2020 15:45, sebb wrote: > > I've

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Mark Thomas
On 16/08/2020 15:45, sebb wrote: > I've pushed change to the pom which allows compilation on Java14. > > Will that suffice? That certainly works for me. Thanks for doing this. Mark > > On Sun, 16 Aug 2020 at 15:29, sebb wrote: >> >> On Sun, 16 Aug 2020 at 11:13, Xeno Amess wrote: >>> >>> I

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread sebb
I've pushed change to the pom which allows compilation on Java14. Will that suffice? On Sun, 16 Aug 2020 at 15:29, sebb wrote: > > On Sun, 16 Aug 2020 at 11:13, Xeno Amess wrote: > > > > I suddenly arise a good idea... > > How about > > 1. we release a java 7 version of this repo. > > 2. we wai

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread sebb
On Sun, 16 Aug 2020 at 11:13, Xeno Amess wrote: > > I suddenly arise a good idea... > How about > 1. we release a java 7 version of this repo. > 2. we wait for user argue about this. That has already happened ... As noted earlier in this thread, Tomcat needs a version that compiles on Java 6 >

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Rob Tompkins
> On Aug 16, 2020, at 6:08 AM, Mark Thomas wrote: > > On 15/08/2020 19:00, Gary Gregory wrote: >> On Sat, Aug 15, 2020 at 1:14 PM Mark Thomas > > wrote: >> >>> On 10/08/2020 17:26, Gary Gregory wrote: As recently done for [EMAIL], I propose we update [LOGGING] and

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Rob Tompkins
> On Aug 16, 2020, at 6:13 AM, Xeno Amess wrote: > > I suddenly arise a good idea... > How about > 1. we release a java 7 version of this repo. > 2. we wait for user argue about this. > 3. if no users argue about this, we just go forward to 7. Otherwise, we > re-consider about this. That wo

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Xeno Amess
I suddenly arise a good idea... How about 1. we release a java 7 version of this repo. 2. we wait for user argue about this. 3. if no users argue about this, we just go forward to 7. Otherwise, we re-consider about this. Mark Thomas 于 2020年8月16日周日 下午6:08写道: > On 15/08/2020 19:00, Gary Gregory

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-16 Thread Mark Thomas
On 15/08/2020 19:00, Gary Gregory wrote: > On Sat, Aug 15, 2020 at 1:14 PM Mark Thomas wrote: > >> On 10/08/2020 17:26, Gary Gregory wrote: >>> As recently done for [EMAIL], I propose we update [LOGGING] and [DAEMON] >>> from Java 6 to 7 to streamline building on CIs. >> >> -1 for DAEMON. Tomcat

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-15 Thread Gary Gregory
I use Daemon at work quite a bit so yes I've done more than look at it ;-) Right now we can't tell if it will even build and run on Java > 11 since as of Java 12 onwards javac doesn't support building for Java 6. So this -1 is not a good technical argument IMO. The fact that we can't even run a b

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-15 Thread John Patrick
What if you're wanting to use it on Java 14, 15 RC, 16 EA or in 6 months time 17 EA, will they support such an old version? Reading the website; Tomcat 7 needs Java 6 and later and (Java 7 for WebSockets), Tomcat 8 is Java 7 and later Tomcat 9 is Java 8 and later Tomcat 10 is Java 8 and later They

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-15 Thread sebb
On Sat, 15 Aug 2020 at 19:01, Gary Gregory wrote: > > On Sat, Aug 15, 2020 at 1:14 PM Mark Thomas wrote: > > > On 10/08/2020 17:26, Gary Gregory wrote: > > > As recently done for [EMAIL], I propose we update [LOGGING] and [DAEMON] > > > from Java 6 to 7 to streamline building on CIs. > > > > -1 f

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-15 Thread Gary Gregory
On Sat, Aug 15, 2020 at 1:14 PM Mark Thomas wrote: > On 10/08/2020 17:26, Gary Gregory wrote: > > As recently done for [EMAIL], I propose we update [LOGGING] and [DAEMON] > > from Java 6 to 7 to streamline building on CIs. > > -1 for DAEMON. Tomcat 7 depends on it and has a specification mandated

Re: [LOGGING][DAEMON] Update Java 6 to 7

2020-08-15 Thread Mark Thomas
On 10/08/2020 17:26, Gary Gregory wrote: > As recently done for [EMAIL], I propose we update [LOGGING] and [DAEMON] > from Java 6 to 7 to streamline building on CIs. -1 for DAEMON. Tomcat 7 depends on it and has a specification mandated requirement to run on Java 6. Are there any features / bugs

[LOGGING][DAEMON] Update Java 6 to 7

2020-08-10 Thread Gary Gregory
As recently done for [EMAIL], I propose we update [LOGGING] and [DAEMON] from Java 6 to 7 to streamline building on CIs. Gary