Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
On 26 September 2014 14:53, Gary Gregory wrote: > Let's also think about what happens when you to an array into a Map. > > Does the fact that we are dealing with a reflection hashCode API mean it > should give the same key that would be used if you put the array in a map? > > Gary Hi Gary, I don'

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Gary Gregory
Let's also think about what happens when you to an array into a Map. Does the fact that we are dealing with a reflection hashCode API mean it should give the same key that would be used if you put the array in a map? Gary On Fri, Sep 26, 2014 at 7:10 AM, Michael Pigott < mpigott.subscripti...@gm

Re: [LANG] Thoughts on LANG-1039

2014-09-26 Thread Michael Pigott
Hi Duncan, Does it make sense to create a method specifically for array types, which calls reflectonHashCode on each element to compute a final hash code? This would solve the poster's problem and avoid polluting reflectionHashCode with the behavior. Regards, Mike On Sep 26, 2014 6:32 AM, "Dun

[LANG] Thoughts on LANG-1039

2014-09-26 Thread Duncan Jones
Hi folks, I'd welcome someone else's viewpoint on LANG-1039. The question is: what should HashCodeBuilder.reflectionHashCode() do when given an array object as input. My argument is that the intended use of this method is for overriding Object.hashCode() and so it should never be the case than an