Hi,
I've reviewed the current code again and I've come to the conclusion that
we should revert it completely. Here is an example of why I think it need
polishing:
public static void smaller(final long value, final long max, final String
message, final Object... values) {
if (value >= max) {
Am 18.09.2016 um 13:58 schrieb Benedikt Ritter:
The problem with the current API is that we can't get rid of the "Object"
suffix:
public static void different(long, long, String, Object...)
public static void differentObject(T, T, String, Object...)
when I change the second method name to "dif
The problem with the current API is that we can't get rid of the "Object"
suffix:
public static void different(long, long, String, Object...)
public static void differentObject(T, T, String, Object...)
when I change the second method name to "different" (or rename both to
notEquals), the method
Hello,
sebb schrieb am So., 18. Sep. 2016 um 12:21 Uhr:
> I agree; use notEquals, greaterThan, lessThan
>
> 'different' is ambiguous - does it mean notSame or notEquals?
>
the latter.
>
> On 17 September 2016 at 16:57, Gary Gregory
> wrote:
> > JUnit makes the distinction between "same" for
I agree; use notEquals, greaterThan, lessThan
'different' is ambiguous - does it mean notSame or notEquals?
On 17 September 2016 at 16:57, Gary Gregory wrote:
> JUnit makes the distinction between "same" for the same object and "equals"
> and calling equals(), maybe this would help here.
>
> htt
JUnit makes the distinction between "same" for the same object and "equals"
and calling equals(), maybe this would help here.
http://junit.org/junit4/javadoc/4.12/org/junit/Assert.html
Gary
On Sep 17, 2016 7:52 AM, "Benedikt Ritter" wrote:
> Hi,
>
> LANG-1134 introduced new methods to Validate
Hi,
LANG-1134 introduced new methods to Validate. I'm not fond of the API as is
currently is. Here are my concerns:
- When comparing numeral values usually we talk about greaterThan and
lessThan. The new API in Validate uses "smaller" and "greater"
- we have a method called "different" which chec
