Re: [LANG] Findbugs and CheckStyle

2013-10-24 Thread Brent Worden
Lang is using the most recent release of the FindBugs Maven plugin (2.5.2) which uses the more recent release of FindBugs (2.0.2). FindBugs has the means to suppress fall through via comments and its findbugs.sf.comment analysis property [1]. Sadly, the latest version of the FindBugs Maven plugin

Re: [LANG] Findbugs and CheckStyle

2013-10-24 Thread Gary Gregory
You could also check that we are using the current version of the plugins to benefit from any fixes, maybe some false negatives are being generated. G On Thu, Oct 24, 2013 at 2:44 AM, Henri Yandell wrote: > Noting that we've not stopped having Findbugs, Checkstyle and PMD notes > from blocking

Re: [LANG] Findbugs and CheckStyle

2013-10-23 Thread Henri Yandell
Noting that we've not stopped having Findbugs, Checkstyle and PMD notes from blocking a release in the past if we didn't agree with them. Checkstyle should get improved, but it's not a regression (ie: 3.2 would be no worse than 3.1). Hen On Wed, Oct 23, 2013 at 11:21 PM, Benedikt Ritter wrote:

[LANG] Findbugs and CheckStyle

2013-10-23 Thread Benedikt Ritter
Hi guys, there are only two issues left in jira which can be fixed later than 3.2. If you agree feel free to change the Fix version, so that we can move on. I've looked through FindBugs and CheckStyle: CheckStyle: only missing JavaDoc in TypeUtils. To be honest I really don't know what the reflec