Re: [LANG]DurationUtils pull request reminder

I've actually come up with a better solution but I'll have time on weekend On Mon, Mar 18, 2019, 17:51 Eric Barnhill wrote: > I don't have time to unravel this for you, and I am not saying my proposed > idea was the best, but generally it is an antipattern to have a bunch of > similarly named me

Re: [LANG]DurationUtils pull request reminder

I don't have time to unravel this for you, and I am not saying my proposed idea was the best, but generally it is an antipattern to have a bunch of similarly named methods performing approximately the same task. It is a nice idea for a common utility but surely there is a way to implement it where

Re: [LANG]DurationUtils pull request reminder

I was thinking about this, the implementation of Duration class makes it quite hard. If method "public long get(TemporalUnit unit)" from Duration class supported all ChronoUnit it would be pretty easy to do, but with the current implementation I would have to make a lot of switch or if statements s

Re: [LANG]DurationUtils pull request reminder

I think this class is on its way howver I agree with Sebb's comments there has to be more flexibility about the rounding approach. I am not sure a Utils class is the way to handle this flexibility. What about a DurationRounder class or similar. Then an Enum for rounding method: RoundingMethod.ROUN

[LANG]DurationUtils pull request reminder

Hi, I would like to remind abut my pull request : https://github.com/apache/commons-lang/pull/406 I know that you have a lot of work, but please take look at it - this PR was created almost month ago. Aleksander

[LANG] DurationUtils pull request

Hi, I've just opened a pull request for class DurationUtils which contains methods for rounding duration Aleksander