Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Benedikt Ritter
Hello Loic, sounds good to me. Go for it. Benedikt 2015-10-20 9:52 GMT+02:00 Loïc Guibert : > Hello, > I proposed some time ago to add in StringUtils 2 null safe methods > to replace into a String with regular expression > and I'd like to hear opinions about that. > > I opened a JIRA ticket (LA

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Loïc Guibert
Hello, I proposed some time ago to add in StringUtils 2 null safe methods to replace into a String with regular expression and I'd like to hear opinions about that. I opened a JIRA ticket (LANG-1139) : https://issues.apache.org/jira/browse/LANG-1139 and an associated Pull Request (#92) : https://

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-10-20 Thread Loic Guibert
Hello, I proposed some time ago to add in StringUtils 2 null safe methods to replace into a String with regular expression and I'd like to hear opinions about that. I opened a JIRA ticket (LANG-1139) : https://issues.apache.org/jira/browse/LANG-1139 and an associated Pull Request (#92) : https://

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-08-04 Thread Benedikt Ritter
Hello Loic, see my comment on the other thread. When I get the time to release 3.5 I'll have a look at the tickets, promise! ;-) Regards and thank you, Benedikt 2015-07-28 12:20 GMT+02:00 Loic Guibert : > Hello Benedikt, > LANG version 3.5 being about to be released, have you had time to look >

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-07-28 Thread Loic Guibert
Hello Benedikt, LANG version 3.5 being about to be released, have you had time to look at these 2 methods ? https://issues.apache.org/jira/browse/LANG-1139 https://github.com/apache/commons-lang/pull/92 Loic Guibert PGP : 0x65EB4F33 Le 02/06/2015 10:24, Benedikt Ritter a écrit : > Hello Loic, >

Re: [LANG] Adding StringUtils replace by regular expression methods

2015-06-01 Thread Benedikt Ritter
Hello Loic, I really appreciate your effort to get this code into lang. Thank you very much! Sorry that I'm unable to give you timely feedback on the proposed changes. I'm pretty busy at work at the moment and I've almost zero time for OSS right now :-( I'll review the changes as soon as I have so

[LANG] Adding StringUtils replace by regular expression methods

2015-05-28 Thread Loic Guibert
Hello, I implemented 2 null safe methods to replace into a String with regular expression : - String replaceAll(String text, String regex, String replacement); - String replaceFirst(String text, String regex, String replacement); The StringUtils.replacePattern(String source, String regex, Str