Re: [JEXL] Handling of deprecated items in 2.0

2009-08-04 Thread Rahul Akolkar
On Tue, Aug 4, 2009 at 11:42 AM, sebb wrote: > On 04/08/2009, sebb wrote: >> On 03/08/2009, Rahul Akolkar wrote: >>  > On Mon, Aug 3, 2009 at 11:57 AM, sebb wrote: >>  >  > There are some classes and methods which are now deprecated in 2.0. >>  >  > >>  >  > However, the deprecated items are stil

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-04 Thread sebb
On 04/08/2009, sebb wrote: > On 03/08/2009, Rahul Akolkar wrote: > > On Mon, Aug 3, 2009 at 11:57 AM, sebb wrote: > > > There are some classes and methods which are now deprecated in 2.0. > > > > > > However, the deprecated items are still used by much of the test code. > > > > > > See

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread sebb
On 03/08/2009, Rahul Akolkar wrote: > On Mon, Aug 3, 2009 at 11:57 AM, sebb wrote: > > There are some classes and methods which are now deprecated in 2.0. > > > > However, the deprecated items are still used by much of the test code. > > > > Seems to me that the test cases ought not to use de

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread Henrib
..@commons.apache.org > > > Created JEXL-68 & patch. -- View this message in context: http://www.nabble.com/-JEXL--Handling-of-deprecated-items-in-2.0-tp24793279p24798153.html Sent from the Commons - Dev mailing list archive at Nabble.com. -

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread Rahul Akolkar
On Mon, Aug 3, 2009 at 1:30 PM, Henrib wrote: > > > The tests use the ExpressionFactory & ScriptFactory a lot indeed; using a > static JexlEngine in those test classes should be equivalent. > I can refactor these if this helps and I'm not stepping on anyone's toes. That'd be great. -Rahul -

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread Rahul Akolkar
On Mon, Aug 3, 2009 at 11:57 AM, sebb wrote: > There are some classes and methods which are now deprecated in 2.0. > > However, the deprecated items are still used by much of the test code. > > Seems to me that the test cases ought not to use deprecated classes > and methods unless the test is actu

Re: [JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread Henrib
The tests use the ExpressionFactory & ScriptFactory a lot indeed; using a static JexlEngine in those test classes should be equivalent. I can refactor these if this helps and I'm not stepping on anyone's toes. -- View this message in context: http://www.nabble.com/-JEXL--Handling

[JEXL] Handling of deprecated items in 2.0

2009-08-03 Thread sebb
There are some classes and methods which are now deprecated in 2.0. However, the deprecated items are still used by much of the test code. Seems to me that the test cases ought not to use deprecated classes and methods unless the test is actually for testing the item. Any views on this? ---