Re: [IO] SymbolicLinkFileFilter

2023-04-17 Thread Miguel Muñoz
"The class per its javadoc filters for symbolic links on files." It sounds like it's only supposed to pass files that are symbolic links. If that's the idea, the class doesn't work at all. If not, we need a clearer description. As for unit tests, maybe the test should detect the Windows OS and ju

Re: [IO] SymbolicLinkFileFilter

2023-04-17 Thread Miguel Muñoz
Here's a better idea for how to write the unit test. First, we put something in the SymbolicLinkFileFilter class like this: public class SymbolicLinkFileFilter { private static LinkTester linkTester = new LinkTester(); // defined below static setLinkTesterForUnitTests(LinkTester unitTestLinkT

Re: [IO] SymbolicLinkFileFilter

2023-04-14 Thread Gary Gregory
Hi Miguel, Thank you for reviewing. A better unit test would help of course ;-) but testing links can be a pain as the JVM requires admin rights on Windows 10 at least. This might not be an issue for GitHub but be aware of it if you run builds locally. The class per its javadoc filters for symbol