On Sep 30, 2017 02:58, "Benedikt Ritter" wrote:
Okay, I'll cut RC1 this afternoon.
Benedikt
Great!
Gary
Pascal Schumacher schrieb am Sa. 30. Sep. 2017
um 10:47:
> Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
> > Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
> > :
> >> Am 28.09.2017
Okay, I'll cut RC1 this afternoon.
Benedikt
Pascal Schumacher schrieb am Sa. 30. Sep. 2017
um 10:47:
> Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
> > Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
> > :
> >> Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
> >>> The new error is:
> >>
Am 30.09.2017 um 10:26 schrieb Benedikt Ritter:
Am 28.09.2017 um 09:39 schrieb Pascal Schumacher
:
Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
The new error is:
FileSystemUtilsTestCase.testGetFreeSpace_String:89
expected:<1.02861164E8> but was:<1.0286066E8>
I have:
5
> Am 28.09.2017 um 09:39 schrieb Pascal Schumacher :
>
> Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
>> The new error is:
>> FileSystemUtilsTestCase.testGetFreeSpace_String:89
>> expected:<1.02861164E8> but was:<1.0286066E8>
>>
>> I have:
>>5 Dir(s) 104,991,649,792 byt
Am 28.09.2017 um 00:14 schrieb Stian Soiland-Reyes:
The new error is:
FileSystemUtilsTestCase.testGetFreeSpace_String:89
expected:<1.02861164E8> but was:<1.0286066E8>
I have:
5 Dir(s) 104,991,649,792 bytes free
Test calls:
final long bytes = FileSystemUtils.fre
I only got one error on Windows 10 – thanks for the fixes, Pascal and Gary!
The new error is:
FileSystemUtilsTestCase.testGetFreeSpace_String:89
expected:<1.02861164E8> but was:<1.0286066E8>
I have:
5 Dir(s) 104,991,649,792 bytes free
Test calls:
final long bytes
Great!
That should reduce the number of random test failures.
I was just taking a look at this and the usage patterns of the folder
looked horrible. :/
Cheers,
Pascal
Am 27.09.2017 um 21:19 schrieb Gary Gregory:
I updated the tests to use JUnit's TemporaryFolder rule instead of the old
cust
I updated the tests to use JUnit's TemporaryFolder rule instead of the old
custom and _shared_ folder. No more random errors.
Gary
On Wed, Sep 27, 2017 at 1:05 PM, Pascal Schumacher wrote:
> Am 27.09.2017 um 19:58 schrieb Gary Gregory:
>
>> I wonder if we need to force Maven to disable any conc
Am 27.09.2017 um 19:58 schrieb Gary Gregory:
I wonder if we need to force Maven to disable any concurrency when running
tests?
That should not be necessary.
Maven/Maven-Surefire-Plugin does not run test in parallel by default.
The surefire configuration of commons-io does not specify the paral
Actually, we should not manage our own test folder, we should let JUnit do
with the TemporaryFolder rule...
Gary
On Wed, Sep 27, 2017 at 11:58 AM, Gary Gregory
wrote:
> But I am also seeing random failures trying to set up and teardown the
> test directory. For example:
>
> java.lang.AssertionE
But I am also seeing random failures trying to set up and teardown the test
directory. For example:
java.lang.AssertionError: Could not create directory
C:\vcs\git\apache\commons\commons-io\target\test_io
at
org.apache.commons.io.IOUtilsTestCase.setUp(IOUtilsTestCase.java:80)
testAsBuffer
I fixed that failure with some Git magic.
Gary
On Wed, Sep 27, 2017 at 12:32 AM, Benedikt Ritter
wrote:
>
> > Am 27.09.2017 um 00:16 schrieb Gary Gregory :
> >
> > This test fails on Windows:
>
> Can’t we just drop Windows support? :(
>
> Do you have some time to investigate this?
>
> Cheers,
>
The current Jenkins build uses Windows:
https://builds.apache.org/view/A-D/view/Commons/job/commons-io/58/
Last few runs were successful.
On 27 September 2017 at 08:46, Pascal Schumacher
wrote:
> Strange.
>
> I just ran the commons-io test three times on windows 10 and every run was
> successf
Strange.
I just ran the commons-io test three times on windows 10 and every run
was successful.
Are you sure that you are not seeing on of the occasional failures that
the io test suffer from?
Am 27.09.2017 um 00:16 schrieb Gary Gregory:
This test fails on Windows:
org.apache.commons.io.F
> Am 27.09.2017 um 00:16 schrieb Gary Gregory :
>
> This test fails on Windows:
Can’t we just drop Windows support? :(
Do you have some time to investigate this?
Cheers,
Benedikt
>
> org.apache.commons.io.FileUtilsTestCase
>
> FileUtilsTestCase
> org.apache.commons.io.FileUtilsTestCase
> te
There used to be Windows Jenkins slaves. I had them configured for Log4j
here: https://builds.apache.org/job/Log4jWindows/
Not sure if they're working properly, but I see 3 nodes:
https://builds.apache.org/label/Windows/
On 26 September 2017 at 17:52, Bruno P. Kinoshita wrote:
> I wonder if we
I wonder if we have some windows jenkins slaves. It would be nice to identify
these regressions earlier.
Bruno
Sent from Yahoo Mail on Android
On Wed, 27 Sep 2017 at 8:16, Gary Gregory wrote:
This test fails on Windows:
org.apache.commons.io.FileUtilsTestCase
FileUtilsTestCase
org.apach
This test fails on Windows:
org.apache.commons.io.FileUtilsTestCase
FileUtilsTestCase
org.apache.commons.io.FileUtilsTestCase
testContentEqualsIgnoreEOL(org.apache.commons.io.FileUtilsTestCase)
java.lang.AssertionError
at org.junit.Assert.fail(Assert.java:86)
at org.junit.Assert.assertTrue(Asse
Great new! Thanks!
Am 26.09.2017 um 22:48 schrieb Benedikt Ritter:
Hey,
I’m going through the list of components I happen to work with and make them
ready for Java 9. Since I’m blocked in the release process of collections
because of the Windows test failures, I’m going to cut a RC for IO 2.6
Go for it! :-)
Gary
On Tue, Sep 26, 2017 at 2:48 PM, Benedikt Ritter wrote:
> Hey,
>
> I’m going through the list of components I happen to work with and make
> them ready for Java 9. Since I’m blocked in the release process of
> collections because of the Windows test failures, I’m going to cu
Hey,
I’m going through the list of components I happen to work with and make them
ready for Java 9. Since I’m blocked in the release process of collections
because of the Windows test failures, I’m going to cut a RC for IO 2.6 probably
tomorrow night.
Regards,
Benedikt
21 matches
Mail list logo
