Re: [IO] Input parameter checking

2015-05-22 Thread sebb
On 22 May 2015 at 08:14, Gary Gregory wrote: > My first inclination is to leave it all as is in this dept. Otherwise, all > public APIs would be candidate for parameter validation. That would be a > lot of extra code. The difference being when and what exception is thrown. > > It's not clear to me

Re: [IO] Input parameter checking

2015-05-22 Thread Gary Gregory
My first inclination is to leave it all as is in this dept. Otherwise, all public APIs would be candidate for parameter validation. That would be a lot of extra code. The difference being when and what exception is thrown. It's not clear to me that there is a lot of value there since [io] is a pret

[IO] Input parameter checking

2015-05-21 Thread Benedikt Ritter
Hi, I've noticed that there are some classes that do not validate input parameters. For example the constructor o.a.c.io.output.XmlStreamWriter(final OutputStream out, final String defaultEncoding) does not check whether out is null, which will lead to late failure in detectEncoding(final char[]