Re: [IO] CharSequenceReader improvements

2020-07-11 Thread Rob Spoor
Thanks! On 10/07/2020 14:25, Gary Gregory wrote: Thanks Rob, I merged both PRs to master. Gary On Wed, Jul 8, 2020 at 3:49 PM Rob Spoor wrote: Hi, I was replacing my own copy of CharSequenceReader with the one from commons-io, but I had some test failures. I found out that there were two r

Re: [IO] CharSequenceReader improvements

2020-07-10 Thread Gary Gregory
Thanks Rob, I merged both PRs to master. Gary On Wed, Jul 8, 2020 at 3:49 PM Rob Spoor wrote: > Hi, > > I was replacing my own copy of CharSequenceReader with the one from > commons-io, but I had some test failures. I found out that there were > two reasons: > > * It doesn't override ready(), a

[IO] CharSequenceReader improvements

2020-07-08 Thread Rob Spoor
Hi, I was replacing my own copy of CharSequenceReader with the one from commons-io, but I had some test failures. I found out that there were two reasons: * It doesn't override ready(), and therefore always returns false, even if there are still characters to be read. That's not incorrect ac