[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2018-02-14 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/49#discussion_r168275645 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -58,8 +60,12 @@ */ public a

[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2018-02-14 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/49#discussion_r168274256 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -58,8 +60,12 @@ */ public a

[GitHub] commons-rdf pull request #43: COMMONSRDF-49: Make AbstractRDFParser serializ...

2018-02-14 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/43 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2018-02-14 Thread ajs6f
Github user ajs6f commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/49#discussion_r168260775 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -58,8 +60,12 @@ */ public a

[GitHub] commons-rdf pull request #48: Cleanup in commons-rdf-rdf4j to close PMD and ...

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/48 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #50: Cleanup for PMD warnings in -rdf-api

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/50 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2018-02-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/49#discussion_r167732171 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -58,8 +60,12 @@ */ public a

[GitHub] commons-rdf pull request #52: Adding convenient Dataset and DatasetGraph con...

2018-02-12 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/52 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #47: COMMONSRDF-67: Make commons-rdf buildable on J...

2018-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/47 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #45: COMMONSRDF-71: Update Javadocs link for RDF4J

2018-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/45 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #46: Add .DS_Store to .gitignore (Mac OS X system f...

2018-01-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/46 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #52: Adding convenient Dataset and DatasetGraph con...

2018-01-29 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/52 Adding convenient Dataset and DatasetGraph conversions PR for COMMONSRDF-74. You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf

[GitHub] commons-rdf pull request #51: 0.5.0 Release Candidate

2017-12-22 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/51 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #51: 0.5.0 Release Candidate

2017-12-22 Thread wikier
GitHub user wikier opened a pull request: https://github.com/apache/commons-rdf/pull/51 0.5.0 Release Candidate You can merge this pull request into a Git repository by running: $ git pull https://github.com/apache/commons-rdf 0.5.0-RC Alternatively you can review and apply t

[GitHub] commons-rdf pull request #50: Cleanup for PMD warnings in -rdf-api

2017-12-14 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/50 Cleanup for PMD warnings in -rdf-api You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf CleanupAPI Alternatively you can revie

[GitHub] commons-rdf pull request #49: Cleanup for FindBugs and PMD warnings in -simp...

2017-12-14 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/49 Cleanup for FindBugs and PMD warnings in -simple and -jena You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf JenaSimpleCleanup

[GitHub] commons-rdf pull request #48: Cleanup in commons-rdf-rdf4j to close PMD and ...

2017-12-14 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/48 Cleanup in commons-rdf-rdf4j to close PMD and FindBugs warnings You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf RDF4jCleanup

[GitHub] commons-rdf pull request #47: COMMONSRDF-67

2017-11-20 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/47 COMMONSRDF-67 The current japicmp maven plugin requires a number of javaee libraries that are not available on JDK 9. Until this is fixed in the upstream project, this adds the required d

[GitHub] commons-rdf pull request #46: Add .DS_Store to .gitignore (Mac OS X system f...

2017-11-20 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/46 Add .DS_Store to .gitignore (Mac OS X system file) You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf patch-1 Alternatively yo

[GitHub] commons-rdf pull request #45: COMMONSRDF-71

2017-11-20 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/45 COMMONSRDF-71 Updates location of RDF4J javadocs link You can merge this pull request into a Git repository by running: $ git pull https://github.com/acoburn/commons-rdf COMMONSRDF-71 Alte

[GitHub] commons-rdf pull request #43: COMMONSRDF-49: Make AbstractRDFParser serializ...

2017-11-15 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/43#discussion_r151267617 --- Diff: commons-rdf-simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -200,19 +200,19 @@ *

[GitHub] commons-rdf pull request #44: COMMONSRDF-70: Upgrade Jena version to 3.5.0

2017-11-13 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/44 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #44: COMMONSRDF-70: Upgrade Jena version to 3.5.0

2017-11-03 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/44 COMMONSRDF-70: Upgrade Jena version to 3.5.0 You can merge this pull request into a Git repository by running: $ git pull https://github.com/ajs6f/commons-rdf COMMONSRDF-70 Alternatively yo

[GitHub] commons-rdf pull request #43: COMMONSRDF-49: Make AbstractRDFParser serializ...

2017-11-02 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/43 COMMONSRDF-49: Make AbstractRDFParser serializable Very simple approach-- I just exposed the values of the fields internally and made the accessors keep producing `Optional`. My understanding is

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-11-01 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/42 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147886874 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147883486 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread wikier
Github user wikier commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147883290 --- Diff: jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread christopher-johnson
Github user christopher-johnson commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147875892 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Ove

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701690 --- Diff: jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java --- @@ -7,7 +7,7 @@ * "License"); you may not use this file except in com

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread afs
Github user afs commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/42#discussion_r147701840 --- Diff: jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java --- @@ -149,7 +149,7 @@ public long size() { @Override p

[GitHub] commons-rdf pull request #42: COMMONSRDF-66: fixes RIOT exception in JenaDat...

2017-10-30 Thread christopher-johnson
GitHub user christopher-johnson opened a pull request: https://github.com/apache/commons-rdf/pull/42 COMMONSRDF-66: fixes RIOT exception in JenaDatasetImpl Lang.NT is not supported by registryDataset. Opts for Lang.NQUADS as a default replacement. adds test You can merge th

[GitHub] commons-rdf pull request #41: COMMONSRDF-65

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/41 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #40: COMMONSRDF-64: Adds Automatic-Module-Name to t...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/40 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #39: COMMONSRDF-62 : Ignore japicmp by default whil...

2017-09-28 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/39 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #41: COMMONSRDF-65

2017-09-28 Thread ajs6f
GitHub user ajs6f opened a pull request: https://github.com/apache/commons-rdf/pull/41 COMMONSRDF-65 https://issues.apache.org/jira/browse/COMMONSRDF-65 Also a small fix for problems building on Mac, and includes https://github.com/apache/commons-rdf/pull/39/ to fix COMMONS

[GitHub] commons-rdf pull request #40: Adds Automatic-Module-Name to the bundle manif...

2017-09-13 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/40 Adds Automatic-Module-Name to the bundle manifests Resolves COMMONSRDF-64 You can merge this pull request into a Git repository by running: $ git pull https://github.com/acoburn/commons-rdf

[GitHub] commons-rdf pull request #38: COMMONSRDF-62 japicmp-maven-plugin breaking bu...

2017-09-12 Thread lewismc
Github user lewismc closed the pull request at: https://github.com/apache/commons-rdf/pull/38 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-rdf pull request #38: COMMONSRDF-62 japicmp-maven-plugin breaking bu...

2017-09-12 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/38#discussion_r138501891 --- Diff: README.md --- @@ -102,6 +102,9 @@ Building has been tested with [Apache Maven 3.2](http://maven.apache.org/downloa [INFO] Final Memory:

[GitHub] commons-rdf pull request #39: COMMONSRDF-62 : Ignore japicmp by default whil...

2017-09-12 Thread ansell
GitHub user ansell opened a pull request: https://github.com/apache/commons-rdf/pull/39 COMMONSRDF-62 : Ignore japicmp by default while version is 0.x japicmp is activated by commons-parent profile with it set to break the build on any incompatibilities. In order to have it still ru

[GitHub] commons-rdf pull request #38: COMMONSRDF-62 japicmp-maven-plugin breaking bu...

2017-09-12 Thread lewismc
GitHub user lewismc opened a pull request: https://github.com/apache/commons-rdf/pull/38 COMMONSRDF-62 japicmp-maven-plugin breaking build because there is atleast one incompatibility This issue addresses https://issues.apache.org/jira/browse/COMMONSRDF-62 You can merge this pull r

[GitHub] commons-rdf pull request #34: COMMONSRDF-60: update commons-parent version

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/34 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #33: COMMONSRDF-59 - fix minor javadocs warnings

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/33 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #37: Minor documentation updates

2017-05-10 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/37 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #37: Minor documentation updates

2017-05-09 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/37 Minor documentation updates As can be seen on [this javadoc page]( https://commons.apache.org/proper/commons-rdf/apidocs/org/apache/commons/rdf/api/package-summary.html), some of the docume

[GitHub] commons-rdf pull request #36: Test

2017-05-04 Thread Imdapro
Github user Imdapro closed the pull request at: https://github.com/apache/commons-rdf/pull/36 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #36: Test

2017-05-04 Thread Imdapro
GitHub user Imdapro opened a pull request: https://github.com/apache/commons-rdf/pull/36 Test A jacoco működik. You can merge this pull request into a Git repository by running: $ git pull https://github.com/Imdapro/commons-rdf test Alternatively you can review and apply the

[GitHub] commons-rdf pull request #35: Codereview

2017-04-27 Thread thereallacas
Github user thereallacas closed the pull request at: https://github.com/apache/commons-rdf/pull/35 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the featu

[GitHub] commons-rdf pull request #35: Codereview

2017-04-27 Thread thereallacas
GitHub user thereallacas opened a pull request: https://github.com/apache/commons-rdf/pull/35 Codereview A manuális code review során felmerült apróbb és nagyobb code smellek javítása. You can merge this pull request into a Git repository by running: $ git pull https://

[GitHub] commons-rdf pull request #34: COMMONSRDF-60: update commons-parent version

2017-03-10 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/34 COMMONSRDF-60: update commons-parent version This upgrades the parent pom to the latest version of `commons-parent`. You can merge this pull request into a Git repository by running: $ git

[GitHub] commons-rdf pull request #33: COMMONSRDF-59 - fix minor javadocs warnings

2017-03-10 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/33 COMMONSRDF-59 - fix minor javadocs warnings This add some missing `@return` values, fixes an HTML error and adds some text to two otherwise undocumented parameters. You can merge this pull requ

[GitHub] commons-rdf pull request #:

2017-02-17 Thread nguyenhoan
Github user nguyenhoan commented on the pull request: https://github.com/apache/commons-rdf/commit/ed787cf7fef42c197f77a66d78ced2a6e6ef0398#commitcomment-20942456 In rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF4J.java: In rdf4j/src/main/java/org/apache/commons/rdf/rdf4j/RDF

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-16 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/27 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100211712 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100209281 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -91,7 +148,30 @@ * Datasets. */ public boolean sup

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-02-08 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r100208441 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -178,17 +206,62 @@ private RDFSyntax(final String name, final String mediaType

[GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/30 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #32: COMMONSRDF-55: Handle Jena's urn:x-arq:Default...

2017-02-08 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/32 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #32: COMMONSRDF-55: Handle Jena's urn:x-arq:Default...

2017-01-27 Thread stain
GitHub user stain opened a pull request: https://github.com/apache/commons-rdf/pull/32 COMMONSRDF-55: Handle Jena's urn:x-arq:DefaultGraph and friends This fixes [COMMONSRDF-55](https://issues.apache.org/jira/browse/COMMONSRDF-55) by adding special testing of Jena's `urn:x-arq:Defa

[GitHub] commons-rdf pull request #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm

2017-01-27 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/31 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #31: COMMONSRDF-54: overloads of RDF4J#asRDFTerm

2017-01-25 Thread ghxiao
GitHub user ghxiao opened a pull request: https://github.com/apache/commons-rdf/pull/31 COMMONSRDF-54: overloads of RDF4J#asRDFTerm Resolves: COMMONSRDF-54 This PR adds three overloaded methods into the class RDF4J: RDF4JBlankNode asRDFTerm(final org.eclipse.rdf4j.m

[GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...

2017-01-16 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/30#discussion_r96309778 --- Diff: api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java --- @@ -194,6 +194,114 @@ public void testCreateLiteralLangISO693_3() throws E

[GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...

2017-01-16 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/30#discussion_r96309546 --- Diff: api/src/test/java/org/apache/commons/rdf/api/AbstractRDFTest.java --- @@ -194,6 +194,114 @@ public void testCreateLiteralLangISO693_3() throws E

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95894599 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -178,17 +206,62 @@ private RDFSyntax(final String name, final String mediaType

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread ansell
Github user ansell commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95893698 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -91,7 +148,30 @@ * Datasets. */ public boolean sup

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread acoburn
Github user acoburn commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95862649 --- Diff: api/src/test/java/org/apache/commons/rdf/api/RDFSyntaxTest.java --- @@ -114,8 +116,7 @@ public void name() throws Exception { @Te

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95843235 --- Diff: simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -240,7 +240,7 @@ public T rdfTermFactory(RDF rdfTer

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95843006 --- Diff: simple/src/main/java/org/apache/commons/rdf/simple/experimental/AbstractRDFParser.java --- @@ -240,7 +240,7 @@ public T rdfTermFactory(RDF rdfTer

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95841290 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -34,7 +152,7 @@ * 1.1 Primer * @see org.apache.commons.rdf.expe

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95841065 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF s

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95840655 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF s

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95840484 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF s

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95840249 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF s

[GitHub] commons-rdf pull request #27: COMMONSRDF-47 RDFSyntax as an interface

2017-01-12 Thread stain
Github user stain commented on a diff in the pull request: https://github.com/apache/commons-rdf/pull/27#discussion_r95840179 --- Diff: api/src/main/java/org/apache/commons/rdf/api/RDFSyntax.java --- @@ -22,6 +22,124 @@ import java.util.Optional; /** + * An RDF s

[GitHub] commons-rdf pull request #30: COMMONSRDF-51 language tags compared lower cas...

2017-01-12 Thread stain
GitHub user stain opened a pull request: https://github.com/apache/commons-rdf/pull/30 COMMONSRDF-51 language tags compared lower case This fixes [COMMONSRDF-51](https://issues.apache.org/jira/browse/COMMONSRDF-51) - at least from `Literal.equals()` and `Literal.hashCode()`

[GitHub] commons-rdf pull request #29: [COMMONSRDF-53] Add ServiceLoader support in O...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/29 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #29: [COMMONSRDF-53] Add ServiceLoader support in O...

2017-01-11 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/29 [COMMONSRDF-53] Add ServiceLoader support in OSGi Resolves: COMMONSRDF-53 This adds bundle metadata for the commons-rdf modules to make it easier to work with the Java `ServiceLoader` i

[GitHub] commons-rdf pull request #28: COMMONSRDF-52 set distinct Bundle-SymbolicName...

2017-01-11 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/commons-rdf/pull/28 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is

[GitHub] commons-rdf pull request #28: set distinct Bundle-SymbolicName values

2017-01-03 Thread acoburn
GitHub user acoburn opened a pull request: https://github.com/apache/commons-rdf/pull/28 set distinct Bundle-SymbolicName values In the 0.3.0-incubating release, all of the commons-rdf components have the same `Symbolic-BundleName`, namely: `org.apache.commons.rdf`. This makes it i