[GitHub] commons-imaging pull request #30: add-tests

2017-09-19 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r139785201 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java --- @@ -1,3 +1,19 @@ +/* --- End diff --

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132311416 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Understand your point.

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132310660 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Indeed, and I may even use it

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132308184 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- Well, Equalsverifier ch

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132307800 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java --- @@ -0,0 +1,55 @@ +/* + * Licens

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132306981 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache S

[GitHub] commons-imaging pull request #30: add-tests

2017-08-09 Thread TheRealHaui
Github user TheRealHaui commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r132306138 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache S

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538892 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softwar

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538887 --- Diff: src/test/java/org/apache/commons/imaging/formats/pnm/PgmFileInfoTest.java --- @@ -0,0 +1,49 @@ +/* + * Licensed to the Apache Softwar

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538792 --- Diff: pom.xml --- @@ -209,6 +209,12 @@ 2.5 test + --- End diff -- -0 Looks like it reduces the

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538871 --- Diff: src/test/java/org/apache/commons/imaging/formats/jpeg/xmp/JpegXmpParserTest.java --- @@ -1,3 +1,19 @@ +/* --- End diff -- G

[GitHub] commons-imaging pull request #30: add-tests

2017-08-06 Thread kinow
Github user kinow commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/30#discussion_r131538915 --- Diff: src/test/java/org/apache/commons/imaging/formats/tiff/taginfos/TagInfoByteOrShortTest.java --- @@ -0,0 +1,55 @@ +/* + * Licensed to

[GitHub] commons-imaging pull request #30: add-tests

2017-07-31 Thread TheRealHaui
GitHub user TheRealHaui opened a pull request: https://github.com/apache/commons-imaging/pull/30 add-tests Added new Unit Tests. You can merge this pull request into a Git repository by running: $ git pull https://github.com/TheRealHaui/commons-imaging add-tests Alternatively