[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Improvements made in #28. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enable

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Yes, you want a fresh PR. Gary On Mon, Jul 17, 2017 at 9:59 AM, TheRealHaui wrote: > As the pull request is already closed shall I reopen another with the s

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 As the pull request is already closed shall I reopen another with the same name? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 The CI fails due to the GrayscaleRountripTest which wasn't changed by me. As it runs locally on my side I consider the timeout problem issued by the Travis server to be a local problem

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory Here we go, directory naming problem solved. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Well, now I did a "mvn clean verify". It didn't complain about anything than for too less code coverage. However, I've checked what you claimed referring the "directory structu

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Did you try a build like "mvn clean verify"? This PR format seems bogus as it contains folders like "org.apache.commons.imaging.common.itu_t4" instead "org/apache/commons/imagin

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just sent it to you via email. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature e

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Under what name? Feel free to email me at ggreg...@apache.org if you do not want to state your name here. --- If your project is set up for it, you can reply to this email and have your

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 Just submitted my ICLA to secret...@apache.org. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not ha

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory Thanks for your response. Looked over the secretary@ section ... Referring to your question if some of the tests were generated: I use a lot of tools on

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Please see https://www.apache.org/licenses/#submitting --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user TheRealHaui commented on the issue: https://github.com/apache/commons-imaging/pull/27 @garydgregory You're welcome. Where to send the pdf to? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pr

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 @TheRealHaui: Thank you for your PR. This is a lot of code, I think it would be appropriate for you to file a ICLA with us. Please see https://www.apache.org/licenses/

[GitHub] commons-imaging issue #27: Increase code coverage one

Github user garydgregory commented on the issue: https://github.com/apache/commons-imaging/pull/27 Where some of these generated? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature