Re: [GEOMETRY] Quickhull Implementation

2023-02-02 Thread Andreas Goss
Hello, thank you very much! I am looking forward to your review comments since this is my first time trying to contribute to an open source project. I also noticed a few things with my code, that should be corrected. Some comments don’t make sense and there shouldn’t be any need for ordering the e

Re: [GEOMETRY] Quickhull Implementation

2023-01-31 Thread Matt Juntunen
Hello! Andreas, thank you for your contribution! It's good to see some work going into commons-geometry since I've had to step away recently. Gilles is right in that we didn't include the hull module in the 1.0 release because I felt like it still needed work. What I'd like to do is remove that mo

Re: [GEOMETRY] Quickhull Implementation

2023-01-29 Thread Andreas Goss
Thanks for the quick reply. I need to create an Jira account first for that. I requested an account by writing to priv...@commons.apache.org Kind Regards Andreas Gilles Sadowski schrieb am Mo. 30. Jan. 2023 um 00:11: > Hello. > > Le dim. 29 janv. 2023 à 19:25, Andreas Goss > a écrit : > > > >

Re: [GEOMETRY] Quickhull Implementation

2023-01-29 Thread Gilles Sadowski
Hello. Le dim. 29 janv. 2023 à 19:25, Andreas Goss a écrit : > > Hello, > > I want to contribute a solution for the open Jira task GEOMETRY-110 ( > https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-110?filter=allopenissues). > I tried my best to organize the code according to guide

[GEOMETRY] Quickhull Implementation

2023-01-29 Thread Andreas Goss
Hello, I want to contribute a solution for the open Jira task GEOMETRY-110 ( https://issues.apache.org/jira/projects/GEOMETRY/issues/GEOMETRY-110?filter=allopenissues). I tried my best to organize the code according to guidelines and at least the maven build was succesful. I created a pull-request