Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Gary Gregory
It looks like not closing a pool negatively affected the test. Gary On Mon, Apr 1, 2019 at 12:22 PM Zheng Feng wrote: > The https://travis-ci.org/apache/commons-dbcp looks good to me. How did > this exception happen ? > > On Mon, Apr 1, 2019 at 11:49 PM Gary Gregory > wrote: > > > Thanks! Now

Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Zheng Feng
The https://travis-ci.org/apache/commons-dbcp looks good to me. How did this exception happen ? On Mon, Apr 1, 2019 at 11:49 PM Gary Gregory wrote: > Thanks! Now this is failing :-( > > java.sql.SQLException: Unable to enlist connection because the transaction > has been garbage collected > at >

Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Gary Gregory
Thanks! Now this is failing :-( java.sql.SQLException: Unable to enlist connection because the transaction has been garbage collected at org.apache.commons.dbcp2.managed.TransactionContext.getTransaction(TransactionContext.java:186) at org.apache.commons.dbcp2.managed.TransactionContext.setSharedC

Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Gary Gregory
Fixed in git master. Gary On Mon, Apr 1, 2019 at 11:43 AM Gary Gregory wrote: > Tracking here: https://issues.apache.org/jira/browse/DBCP-542 > > Gary > > On Mon, Apr 1, 2019 at 11:41 AM Gary Gregory > wrote: > >> Thanks! Now this is failing :-( >> >> java.sql.SQLException: Unable to enlist co

Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Gary Gregory
Tracking here: https://issues.apache.org/jira/browse/DBCP-542 Gary On Mon, Apr 1, 2019 at 11:41 AM Gary Gregory wrote: > Thanks! Now this is failing :-( > > java.sql.SQLException: Unable to enlist connection because the transaction > has been garbage collected > at > org.apache.commons.dbcp2.ma

Re: [DBCP] Broken test on Java 11

2019-04-01 Thread Zheng Feng
Hi Gray, I tried the following patch to use the application class loader and it works on the JDK11. diff --git a/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java b/src/test/java/org/apache/commons/dbcp2/managed/TestSynchronizationOrder.java index 0d35be7e..62333433 100

[DBCP] Broken test on Java 11

2019-03-31 Thread Gary Gregory
Hi All: I need help getting DBCP to pass its tests on Java 11. org.apache.commons.dbcp2.managed.TestSynchronizationOrder currently fails with: java.lang.IllegalArgumentException: javax.sql.XADataSource referenced from a method is not visible from class loader at java.base/java.lang.reflect.Proxy