Re: [Compress] Pack200Exceptions on Old packed files

2021-11-10 Thread Gary Gregory
Our pack200 support was picked up and integrated from the now defunct Apache Harmony; beyond that, we all have to learn it as it lays in our repo. I'm afraid I do not have much to offer beyond moral support and PR reviews; -) I'll learn and review as you go... Gary On Fri, Nov 5, 2021, 19:04 Eric

Re: [Compress] Pack200Exceptions on Old packed files

2021-11-05 Thread Eric Bresie
Where in the current implementation might one look for these sorts of things? In the quoted code seems to focus on the SegmentHeader related details would something around this be needed? I see some of the major/minor may be based on read code and relate to the Codec in use. While looking for Seg

Re: [Compress] Pack200Exceptions on Old packed files

2021-10-31 Thread Gary Gregory
Some sample pack200 files should also be part of tests. Gary On Thu, Oct 28, 2021, 10:16 Gary Gregory wrote: > You'll have to figure out the implementation details but I will be happy > to review PRs on GitHub. > > Gary > > On Thu, Oct 28, 2021, 08:32 Eric Bresie wrote: > >> In this particular

Re: [Compress] Pack200Exceptions on Old packed files

2021-10-28 Thread Gary Gregory
You'll have to figure out the implementation details but I will be happy to review PRs on GitHub. Gary On Thu, Oct 28, 2021, 08:32 Eric Bresie wrote: > In this particular case, there were packed modules which had major / minor > versions not equal to the Major version 7 or minor version 150 sup

Re: [Compress] Pack200Exceptions on Old packed files

2021-10-28 Thread Eric Bresie
In this particular case, there were packed modules which had major / minor versions not equal to the Major version 7 or minor version 150 supported in the code. This results in the exception, preventing it from unpacking. The need is to be able to unpack an older packed file. As I understand it,

Re: [Compress] Pack200Exceptions on Old packed files

2021-10-26 Thread Gary Gregory
There is not. The intent of the current code is simply to provide functionality that was dropped from the JRE. What newer versions and how are they different? Gary On Tue, Oct 26, 2021, 13:49 Eric Bresie wrote: > While trying to unpack an older generated pack file, it was noted that > Pack200

[Compress] Pack200Exceptions on Old packed files

2021-10-26 Thread Eric Bresie
While trying to unpack an older generated pack file, it was noted that Pack200Exceptions were getting raised due to the Major/Minor Version in used which seems to be I this area. https://github.com/apache/commons-compress/blob/master/src/main/java/org/apache/commons/compress/harmony/unpack200/Se