Re: [CSV][POLL] How to provide mutable records

2018-02-13 Thread Stian Soiland-Reyes
On Mon, 12 Feb 2018 18:10:56 -0700, Gary Gregory wrote: > On Fri, Feb 9, 2018 at 10:05 AM, Stian Soiland-Reyes > I've not had time to review this yet but I hope to get to it sometimes this > week. Thanks. I'll wait for that before prepping a 1.6 RC so we get time to decide if this is in or not.

Re: [CSV][POLL] How to provide mutable records

2018-02-12 Thread Gary Gregory
On Fri, Feb 9, 2018 at 10:05 AM, Stian Soiland-Reyes wrote: > On Fri, 25 Aug 2017 19:19:58 +0100, Stian Soiland-Reyes > wrote: > > This came up also for commons rdf where we also have everything > immutable, > > which I think is a good principle to keep for modern Java 8 programming. > > > > So

Re: [CSV][POLL] How to provide mutable records

2018-02-09 Thread Stian Soiland-Reyes
On Fri, 25 Aug 2017 19:19:58 +0100, Stian Soiland-Reyes wrote: > This came up also for commons rdf where we also have everything immutable, > which I think is a good principle to keep for modern Java 8 programming. > > So you need a mutator function like in (4) that either returns a new > immuta

Re: [CSV][POLL] How to provide mutable records

2017-08-25 Thread Stian Soiland-Reyes
This came up also for commons rdf where we also have everything immutable, which I think is a good principle to keep for modern Java 8 programming. So you need a mutator function like in (4) that either returns a new immutable (but changed) CSVRecord; or alternatively a different MutableCSVRecord

Re: [CSV][POLL] How to provide mutable records

2017-08-25 Thread Gary Gregory
I really do not like [4], I personally would never want to use such an odd looking API with arrays that I have to build as input. What this super simple "solution", #5: Add a new toArray() method to CSVRecord: /** * Clones a new array. * * @return a new array */ public

Re: [CSV][POLL] How to provide mutable records

2017-08-25 Thread Gary Gregory
On Mon, Aug 21, 2017 at 3:29 PM, sebb wrote: > On 21 August 2017 at 21:04, Gary Gregory wrote: > > Hi All, > > > > We have a request for [CSV] to provide mutable records. There is no clear > > consensus to me on how to do this. The current CSVRecord class is > immutable > > but is not documented

Re: [CSV][POLL] How to provide mutable records

2017-08-22 Thread Oliver Heger
Am 22.08.2017 um 21:34 schrieb Gary Gregory: > On Tue, Aug 22, 2017 at 1:27 PM, Oliver Heger > wrote: > >> >> >> Am 21.08.2017 um 23:29 schrieb sebb: >>> On 21 August 2017 at 21:04, Gary Gregory wrote: Hi All, We have a request for [CSV] to provide mutable records. There is no >

Re: [CSV][POLL] How to provide mutable records

2017-08-22 Thread Gary Gregory
On Tue, Aug 22, 2017 at 1:27 PM, Oliver Heger wrote: > > > Am 21.08.2017 um 23:29 schrieb sebb: > > On 21 August 2017 at 21:04, Gary Gregory wrote: > >> Hi All, > >> > >> We have a request for [CSV] to provide mutable records. There is no > clear > >> consensus to me on how to do this. The curre

Re: [CSV][POLL] How to provide mutable records

2017-08-22 Thread Oliver Heger
Am 21.08.2017 um 23:29 schrieb sebb: > On 21 August 2017 at 21:04, Gary Gregory wrote: >> Hi All, >> >> We have a request for [CSV] to provide mutable records. There is no clear >> consensus to me on how to do this. The current CSVRecord class is immutable >> but is not documented as such. I att

Re: [CSV][POLL] How to provide mutable records

2017-08-21 Thread sebb
On 21 August 2017 at 21:04, Gary Gregory wrote: > Hi All, > > We have a request for [CSV] to provide mutable records. There is no clear > consensus to me on how to do this. The current CSVRecord class is immutable > but is not documented as such. I attribute that to YAGNI up to now. > > Options ra

[CSV][POLL] How to provide mutable records

2017-08-21 Thread Gary Gregory
Hi All, We have a request for [CSV] to provide mutable records. There is no clear consensus to me on how to do this. The current CSVRecord class is immutable but is not documented as such. I attribute that to YAGNI up to now. Options range from simply making CSVRecord immutable to creating a new