Re: [CRYPTO] Utils package

2016-06-18 Thread Gary Gregory
On Jun 18, 2016 5:30 PM, "Stian Soiland-Reyes" wrote: > > +1 to rename crypto.utils it to .internal, and then we are somewhat free to > shrink it in 1.1. > > I see many things in there that could form a minimal Commons Native, e.g. > to help with bundled native libraries and architecture detection

Re: [CRYPTO] Utils package

2016-06-18 Thread sebb
On 19 June 2016 at 01:30, Stian Soiland-Reyes wrote: > +1 to rename crypto.utils it to .internal, and then we are somewhat free to > shrink it in 1.1. Also there are a couple of methods that are only called in one place so should be moved to the calling class: CRYPTO-83 CRYPTO-84 There may be o

Re: [CRYPTO] Utils package

2016-06-18 Thread Stian Soiland-Reyes
+1 to rename crypto.utils it to .internal, and then we are somewhat free to shrink it in 1.1. I see many things in there that could form a minimal Commons Native, e.g. to help with bundled native libraries and architecture detection. While perhaps less people deal with JNI now than 10 years ago, s

[CRYPTO] Utils package

2016-06-12 Thread Benedikt Ritter
Hi, looking through the code I wonder what to do with the utils package. It looks like the typical "don't know where to put this peace of code"-dumping ground. I think we should at least mark the whole package as internal. Further more we should change class names: Utils, IOUtils and ReflectionUti