Re: [COMPRESS] Pack200 support in pack200 branch

2020-11-02 Thread Peter Lee
> So we could do 1.21 as is followed by 1.22 with pack200 support. > +1 Lee On 11, 1, 2020, at 11:59, Gary Gregory wrote: > It's been quite a while since this thread started so I will review my > branch today but might wait for 1.22. > > While we indicated that we would address building and runn

Re: [COMPRESS] Pack200 support in pack200 branch

2020-11-01 Thread Gary Gregory
It's been quite a while since this thread started so I will review my branch today but might wait for 1.22. While we indicated that we would address building and running pack200 in some way on Java 14+ for 1.21, an option is to release 1.21 as is since there are quite a few changes there already a

Re: [COMPRESS] Pack200 support in pack200 branch

2020-08-30 Thread Gary Gregory
Hi All, As the next step in the pack200 branch, I've renamed the package org.apache.harmony to org.apache.commons.compress.harmony to more easily track potential future changes. If this looks acceptable, it can be merged and documented. The builds are green here https://github.com/apache/commons-

Re: [COMPRESS] Pack200 support in pack200 branch

2020-08-24 Thread Gary Gregory
Thanks Peter, I updated the branch and the build passes for me locally, the CI is building now here https://github.com/apache/commons-compress/actions/runs/19115 Gary On Sun, Aug 23, 2020 at 11:40 PM Peter Lee wrote: > After some debugging I found this at > org.apache.harmony.pack200.Archi

Re: [COMPRESS] Pack200 support in pack200 branch

2020-08-23 Thread Peter Lee
After some debugging I found this at org.apache.harmony.pack200.Archive#171 : if (classes.size() > 0 && files.size() > 0) { segmentUnitList.add(new SegmentUnit(classes, files)); } Seems the Pack200 implementation in harmony requires existing of both classes AND files at the same time. The tests a

[COMPRESS] Pack200 support in pack200 branch

2020-08-23 Thread Gary Gregory
Hi All, I created a branch called *pack200* which contains the Apache Harmony Pack200 code. If there are 2 failing unit test ATM if anyone wants to help out. Gary