Re: [COLLECTIONS] Trie subclassing

2023-05-03 Thread Claude Warren
I have a work around but not having to convert from binary representation to string would be handy. But it is not critical. I am also not sure that the API is documented all that well. Perhaps I should open a low level ticket that we can work on after 4.5 is released. On Sun, Apr 23, 2023 at 9:

Re: [COLLECTIONS] Trie subclassing

2023-04-23 Thread Gary Gregory
Claude, Do you need the API to be made public? Gary On Mon, Apr 17, 2023 at 2:53 PM Gary Gregory wrote: > > I am guessing that only what is required to be public is as to both maximize > our flexibility in maintenance and minimize the public API surface to support. > > We could make it public

Re: [COLLECTIONS] Trie subclassing

2023-04-17 Thread Gary Gregory
I am guessing that only what is required to be public is as to both maximize our flexibility in maintenance and minimize the public API surface to support. We could make it public if we are sure the API is documented and the code isbas good as we can reasonably make it. Gary On Mon, Apr 17, 202

[COLLECTIONS] Trie subclassing

2023-04-17 Thread Claude Warren
I was looking at the Trie and PatriciaTree class structure from version 4.5 over the weekend. I wanted to build a different implementation with slight modifications. However, there does not seem to be a way to inherit from AbstractPatriciaTrie as it is package protected. Was this intentional or