Re: [CLI] fixing warnings

2011-04-21 Thread Gary Gregory
On Thu, Apr 21, 2011 at 8:03 AM, sebb wrote: > On 21 April 2011 11:59, Emmanuel Bourg wrote: > > Le 21/04/2011 10:21, Simone Tripodi a écrit : > > > >> - @deprecated in the javadoc is for human readability, @Deprecated is > >> for the compiler; > > > > The compiler is fine with the javadoc tag,

Re: [CLI] fixing warnings

2011-04-21 Thread Emmanuel Bourg
Le 21/04/2011 14:03, sebb a écrit : Depends on the compiler target. If you target 1.5 or later, then @Deprecated and @Override should be used. That's your choice, there is no Java police that make these annotations mandatory. The lack of comment associated with the @Deprecated annotation mak

Re: [CLI] fixing warnings

2011-04-21 Thread sebb
On 21 April 2011 11:59, Emmanuel Bourg wrote: > Le 21/04/2011 10:21, Simone Tripodi a écrit : > >>  - @deprecated in the javadoc is for human readability, @Deprecated is >> for the compiler; > > The compiler is fine with the javadoc tag, and the annotation doesn't > provide a useful comment to the

Re: [CLI] fixing warnings

2011-04-21 Thread Emmanuel Bourg
Le 21/04/2011 13:24, Simone Tripodi a écrit : ok, looks like I cannot be very useful here :) have a nice day, good job! Actually you can ! I certainly didn't want to frustrate your enthousiasm, but you have to understand that these kinds of changes (along with javadoc tags, indentation, brace

Re: [CLI] fixing warnings

2011-04-21 Thread Simone Tripodi
ok, looks like I cannot be very useful here :) have a nice day, good job! Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ On Thu, Apr 21, 2011 at 12:59 PM, Emmanuel Bourg wrote: > Le 21/04/2011 10:21, Simone Tripodi a écrit : > >>  - @deprecated in the javadoc is for human

Re: [CLI] fixing warnings

2011-04-21 Thread Emmanuel Bourg
Le 21/04/2011 10:21, Simone Tripodi a écrit : - @deprecated in the javadoc is for human readability, @Deprecated is for the compiler; The compiler is fine with the javadoc tag, and the annotation doesn't provide a useful comment to the user explaining why it's deprecated and what to use in

Re: [CLI] fixing warnings

2011-04-21 Thread Simone Tripodi
Bonjour Emmanuel, recently we had the same discussion about this kind of warnings on [pool] and [discovery] and at the end of them I tend to agree that that should be fixed because: - @deprecated in the javadoc is for human readability, @Deprecated is for the compiler; - @Override: I suggest you

Re: [CLI] fixing warnings

2011-04-21 Thread Emmanuel Bourg
Le 21/04/2011 08:12, Simone Tripodi a écrit : Bonjour Emmanuel! don't worry, since I need to better understand CLI internal code, I just would like to fix minor-minor warnings such Generics, missing @Override/@Deprecated annotations, final fields where possible, etc I don't intend modify the CLI

Re: [CLI] fixing warnings

2011-04-20 Thread Simone Tripodi
Bonjour Emmanuel! don't worry, since I need to better understand CLI internal code, I just would like to fix minor-minor warnings such Generics, missing @Override/@Deprecated annotations, final fields where possible, etc I don't intend modify the CLI code/behavior at all, once I'll feel more famili

Re: [CLI] fixing warnings

2011-04-20 Thread Emmanuel Bourg
Le 20/04/2011 22:49, Simone Tripodi a écrit : Hi all guys, any objection if I provide help on fixing checkstyle/findbugs/compiler warnings? Thank you for helping, but please don't rush, CLI is a very subtle beast that gets easily broken by an apparently innocent change. Emmanuel Bourg smi

Re: [CLI] fixing warnings

2011-04-20 Thread Gary Gregory
Fire away I say. G On Wed, Apr 20, 2011 at 4:49 PM, Simone Tripodi wrote: > Hi all guys, > any objection if I provide help on fixing checkstyle/findbugs/compiler > warnings? > Thanks in advance, > Simo > > http://people.apache.org/~simonetripodi/ > http://www.99soft.org/ > >

[CLI] fixing warnings

2011-04-20 Thread Simone Tripodi
Hi all guys, any objection if I provide help on fixing checkstyle/findbugs/compiler warnings? Thanks in advance, Simo http://people.apache.org/~simonetripodi/ http://www.99soft.org/ - To unsubscribe, e-mail: dev-unsubscr...@commo