Re: [CHAIN] CopyCommand implements two commands at once

2013-06-19 Thread Simone Tripodi
go ahead with copy/override, I think is a nice idea. best, -Simo http://people.apache.org/~simonetripodi/ http://twitter.com/simonetripodi On Tue, Jun 18, 2013 at 9:06 PM, Benedikt Ritter wrote: > > Am 16.06.2013 um 13:46 schrieb Benedikt Ritter : > >> >> Am 15.06.2013 um 15:52 schrieb Benedik

Re: [CHAIN] CopyCommand implements two commands at once

2013-06-18 Thread Benedikt Ritter
Am 16.06.2013 um 13:46 schrieb Benedikt Ritter : > > Am 15.06.2013 um 15:52 schrieb Benedikt Ritter : > >> >> Am 14.06.2013 um 22:36 schrieb Benedikt Ritter : >> >>> Hi, >>> >>> the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands: >>> >>> * a CopyCommand that copies a v

Re: [CHAIN] CopyCommand implements two commands at once

2013-06-16 Thread Benedikt Ritter
Am 15.06.2013 um 15:52 schrieb Benedikt Ritter : > > Am 14.06.2013 um 22:36 schrieb Benedikt Ritter : > >> Hi, >> >> the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands: >> >> * a CopyCommand that copies a value from one key to another >> * an OverrideCommand, that overri

Re: [CHAIN] CopyCommand implements two commands at once

2013-06-15 Thread Benedikt Ritter
Am 14.06.2013 um 22:36 schrieb Benedikt Ritter : > Hi, > > the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands: > > * a CopyCommand that copies a value from one key to another > * an OverrideCommand, that overrides a value with a provided value. We could even extract a Rem

[CHAIN] CopyCommand implements two commands at once

2013-06-14 Thread Benedikt Ritter
Hi, the o.a.c.chain2.generic.CopyCommand IMHO really implements two commands: * a CopyCommand that copies a value from one key to another * an OverrideCommand, that overrides a value with a provided value. What do you think about splitting this up into two separate classes? Regards, Benedikt -