Re: [2/2] commons-crypto git commit: try-with-resources.

2016-06-30 Thread Stian Soiland-Reyes
Agree for readability (and any future stack traces) that .close() should be explicit in the one test case that actually test an early close() doesn't fail :) On 30 June 2016 at 01:22, Gary Gregory wrote: > I disagree with the -1s, but hey, that's just me -1. Reverted. > > G > > On Wed, Jun 29, 20

Re: [2/2] commons-crypto git commit: try-with-resources.

2016-06-29 Thread Gary Gregory
I disagree with the -1s, but hey, that's just me -1. Reverted. G On Wed, Jun 29, 2016 at 5:19 PM, sebb wrote: > On 30 June 2016 at 01:08, wrote: > > try-with-resources. > > > > Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo > > Commit: > http://git-wip-us.apache.org/repos

Re: [2/2] commons-crypto git commit: try-with-resources.

2016-06-29 Thread sebb
On 30 June 2016 at 01:08, wrote: > try-with-resources. > > Project: http://git-wip-us.apache.org/repos/asf/commons-crypto/repo > Commit: http://git-wip-us.apache.org/repos/asf/commons-crypto/commit/b11f6ffa > Tree: http://git-wip-us.apache.org/repos/asf/commons-crypto/tree/b11f6ffa > Diff: http:/