Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/45
Good catch. Maybe at some point we just want to have
http://docs.rdf4j.org/javadoc/latest/ but LGTM.
---
-
To unsubscribe, e
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/51
VOTE passed, see:
https://lists.apache.org/thread.html/c7440213bd41f9839fdce7aab957e686a954affdf5378ff40ea23dbe@%3Cdev.commons.apache.org%3E
GitHub user wikier opened a pull request:
https://github.com/apache/commons-rdf/pull/51
0.5.0 Release Candidate
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/commons-rdf 0.5.0-RC
Alternatively you can review and apply
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/43
Having a little understanding on the concrete use case behind this PR,
generally speaking I normally prefer having the factories/builders implementing
`Serializable`. So in this concrete case I
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/44
Now I think this should definitively go in `0.5.0-RC2`.
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/43
Now that we have aborted `0.5.0-RC1`, do you think this should go in `RC2`?
Honestly I have no much background to really have an opinion on this PR
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/42
LGTM
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user wikier commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/42#discussion_r147886874
--- Diff:
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
@Override
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/42
Please, rebase this PR on top of the current `HEAD` of `master`.
---
-
To unsubscribe, e-mail: dev-unsubscr
Github user wikier commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/42#discussion_r147883486
--- Diff:
jena/src/main/java/org/apache/commons/rdf/jena/impl/JenaDatasetImpl.java ---
@@ -149,7 +149,7 @@ public long size() {
@Override
Github user wikier commented on a diff in the pull request:
https://github.com/apache/commons-rdf/pull/42#discussion_r147883290
--- Diff:
jena/src/test/java/org/apache/commons/rdf/jena/DatasetJenaTest.java ---
@@ -7,7 +7,7 @@
* "License"); you may not use this file
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/39
LGTM
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/34
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/33
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
Github user wikier commented on the issue:
https://github.com/apache/commons-rdf/pull/37
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the
15 matches
Mail list logo
