[GitHub] commons-pool pull request #8: Format DefaultPooledObject getIdleTimeMillis m...

2018-06-18 Thread wangyulin
GitHub user wangyulin opened a pull request: https://github.com/apache/commons-pool/pull/8 Format DefaultPooledObject getIdleTimeMillis method white spaces You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangyulin/commons-pool

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory Thank you for the patient answer, I understand. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-pool pull request #7: Refactor PooledObject and BaseGenericObjectPoo...

2018-06-12 Thread wangyulin
Github user wangyulin closed the pull request at: https://github.com/apache/commons-pool/pull/7 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 @garydgregory In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 In fact, the intention is to move the startEvictionTest and endEvictionTest methods from PooledObject to BaseGenericObjectPool, because eviction is the operation of ObjectPool, not the

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-12 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 **Check checkAPIcompatibility failed:** - org.apache.commons.pool2.PooledObject: Method 'public void setState(org.apache.commons.pool2.PooledObjectState)' has been a

[GitHub] commons-pool issue #7: Refactor PooledObject and BaseGenericObjectPool

2018-06-11 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/7 Add ```getState()``` on ```PooledObject```, checkAPIcompatibility failed. --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-pool pull request #7: Refactor PooledObject and BaseGenericObjectPoo...

2018-06-11 Thread wangyulin
GitHub user wangyulin opened a pull request: https://github.com/apache/commons-pool/pull/7 Refactor PooledObject and BaseGenericObjectPool ```PooledObject``` should not pay attention to ```idleObjects``` of ```GenericObjectPool```, so there should be no ```idleQueue.offerFirst

[GitHub] commons-pool pull request #6: code review

2018-06-10 Thread wangyulin
GitHub user wangyulin opened a pull request: https://github.com/apache/commons-pool/pull/6 code review You can merge this pull request into a Git repository by running: $ git pull https://github.com/wangyulin/commons-pool dev Alternatively you can review and apply these

[GitHub] commons-pool issue #5: Delete repeated call startEvictor

2018-06-08 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/5 @garydgregory Consider whether the problem is reasonable? --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-pool issue #5: Delete repeated call startEvictor

2018-06-08 Thread wangyulin
Github user wangyulin commented on the issue: https://github.com/apache/commons-pool/pull/5 @garydgregory Consider whether the problem is reasonable? --- - To unsubscribe, e-mail: dev-unsubscr

[GitHub] commons-pool pull request #5: Delete repeated call startEvictor

2018-06-08 Thread wangyulin
GitHub user wangyulin opened a pull request: https://github.com/apache/commons-pool/pull/5 Delete repeated call startEvictor Constructor of class `GenericKeyedObjectPool`, `public GenericKeyedObjectPool(final KeyedPooledObjectFactory factory, final GenericKeyedObjectPoolConfig