Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

Hi Gary, the PR did not have conflicts 30 minutes ago. So we must have encountered a race condition between you updating master and me rebasing and force-pushing my pr. I've done that again just now. There are no conflicts. At the same time I see parts of my PR have dribbled into master already,

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

I've removed serialization stuff from the PR and rebased it to master https://github.com/apache/commons-csv/pull/276 kind regards, Markus From: Gary D. Gregory Sent: Friday, October 21, 2022 14:18 To: dev@commons.apache.org Subject: Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1   O

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

> Would't it be simpler to deal with the serialization issue by bumping the > serialVersionID? simpler yes, but it's a different thing The PR makes the serialized forms for commons-csv versions 1.9.0 and 1.10.0 compatible. Given that serialization has been broken for several versions in commons-

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

> You have added test data for CSVFormat for 1.7 and 1.8 and these do not work (commented out). I take it this means serialization has been broken since the CSVFormat.delimiter was changed from char to String in 1.9.0. That's correct, Alex. I added the comments for documentation. Should we decide

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

Hello > This is the logic from the current builder: > DuplicateHeaderMode mode = allowDuplicateHeaderNames ? > DuplicateHeaderMode.ALLOW_ALL : DuplicateHeaderMode.ALLOW_EMPTY This is true only if Builder.setAllowDuplicateHeaderNames is actually called, which is at the library user's discretion.

Re: [VOTE] Release Apache Commons CSV 1.10.0 based on RC1

Hello CSV-264 (Add DuplicateHeaderMode) introduces bugs that should be fixed before shipping 1.10.0 IMO - missing default - broken serialization of class CSVFormat I raised these issues in CSV-302. The serialization issue is caught by Revapi. I had suggested to include Revapi in the project (C

Re: commons-parent: add revapi, drop clirr

commons-parent has two plugins "doing the same thing": japicmp and clirr We drop the one that does not work / is unmaintained and not future-proof (clirr) and replace it by revapi. Still two plugins. Rather than doing the same thing, these plugins complement each other - kind of like Checkstyle

commons-parent: add revapi, drop clirr

Hi, as part of commons-csv pr 252 there is a discussion whether to add revapi-maven-plugin to commons-parent in addition to japicmp-maven-plugin and drop clirr-maven-plugin. The plugins perform checks to ensure source compatibility and binary comp