[GitHub] commons-imaging issue #35: IMAGING-154 Removed Debug class

Github user sebbASF commented on the issue: https://github.com/apache/commons-imaging/pull/35 Agreed --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-imaging pull request #35: IMAGING-154 Removed Debug class

Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-imaging/pull/35#discussion_r210327438 --- Diff: src/main/java/org/apache/commons/imaging/formats/bmp/BmpImageParser.java --- @@ -327,7 +331,7 @@ private BmpImageContents

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/13 FooDiskItem.write is not part of FileUpload, so it *can* throw Exception if it has not been recompiled since it was compiled against FileUpload 1.3.3

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/13 Surely if your new code uses FooDiskFileItem, it needs to know that it throws Exception and catch that accordingly? Why would you knowingly use FooDiskFileItem but not catch Exception

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/13 AFAICT this only affects source compatibility. I was able to run the subclass (throwing Exception) against the base class (updated to throw IOE). Of course I could not compile

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/13 @krichter722 Yes. I meant to say: changing a throw clause can affect source compatibility @garydgregory - are you asking whether an overloaded method will have to be amended

[GitHub] commons-fileupload issue #13: FileItem.java: remove throwing of Exception

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/13 The throws clause is not part of the method signature, and does not affect binary compatibility. However it does affect source compatibilty

[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...

Github user sebbASF commented on the issue: https://github.com/apache/commons-text/pull/46 I've just realised: this issue is about adding CaseUtils.toCamelCase. Problems with WordUtils belong in a separate issue or JIRA --- If your project is set up for it, you can reply to

[GitHub] commons-text issue #46: TEXT-85:Added CaseUtils class with camel case conver...

Github user sebbASF commented on the issue: https://github.com/apache/commons-text/pull/46 An empty delimiter array means the caller does not want any delimiters to be used. But I would expect the output to capitalise the first letter: WordUtils.capitalizeFully("i am

[GitHub] commons-fileupload issue #6: improve GC by avoiding FileInput/Output-Streams

Github user sebbASF commented on the issue: https://github.com/apache/commons-fileupload/pull/6 Note that Oracle still offers (paid) support for versions of Java before 7: http://www.oracle.com/technetwork/java/javase/eol-135779.html#java-commercial-offerings --- If your

[GitHub] commons-compress pull request #21: COMPRESS-388: Fix concurrent reads perfor...

Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/21#discussion_r112838915 --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java --- @@ -,14 +1122,11 @@ public int read() throws IOException

[GitHub] commons-compress pull request #21: COMPRESS-388: Fix concurrent reads perfor...

Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/21#discussion_r112838372 --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java --- @@ -,14 +1122,11 @@ public int read() throws IOException

[GitHub] commons-compress pull request #21: COMPRESS-388: Fix concurrent reads perfor...

Github user sebbASF commented on a diff in the pull request: https://github.com/apache/commons-compress/pull/21#discussion_r112838358 --- Diff: src/main/java/org/apache/commons/compress/archivers/zip/ZipFile.java --- @@ -1081,16 +1082,26 @@ private boolean