[GitHub] commons-pool pull request #17: POOL-359: prevent NPE closing multiple Generi...

2018-11-24 Thread mswintermeyer
Github user mswintermeyer closed the pull request at: https://github.com/apache/commons-pool/pull/17 --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 Also, thank you for merging in the meantime, as well as for contributing your time to maintain the project! --- - To

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 @garydgregory the test was failing on my machine without the main code change, so thanks for flagging that it was not consistent! I've updated the test, and I believe this time i

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-18 Thread mswintermeyer
Github user mswintermeyer commented on the issue: https://github.com/apache/commons-pool/pull/17 If `cancel` should not be called more than once, then I believe that would require a greater re-architecture. `GenericObjectPool`'s would need to keep track of whether another object

[GitHub] commons-pool pull request #17: POOL-359: prevent NPE closing multiple Generi...

2018-11-16 Thread mswintermeyer
GitHub user mswintermeyer opened a pull request: https://github.com/apache/commons-pool/pull/17 POOL-359: prevent NPE closing multiple GenericObjectPool's You can merge this pull request into a Git repository by running: $ git pull https://github.com/mswintermeyer/co