[GitHub] commons-collections issue #24: add-some-Unit-Tests Added some Unit Tests to ...

2017-07-17 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/commons-collections/pull/24 It usually means it was merged manually and closed via a commit message, though it could've been an accident. --- If your project is set up for it, you can reply to this email and have

[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...

2017-06-14 Thread jvz
Github user jvz commented on a diff in the pull request: https://github.com/apache/commons-text/pull/50#discussion_r122104232 --- Diff: src/test/java/org/apache/commons/text/CharacterPredicatesTest.java --- @@ -44,4 +44,77 @@ public void testDigits() { assertFalse

[GitHub] commons-text pull request #50: TEXT-90: Add CharacterPredicates for ASCII le...

2017-06-14 Thread jvz
Github user jvz commented on a diff in the pull request: https://github.com/apache/commons-text/pull/50#discussion_r122104071 --- Diff: src/main/java/org/apache/commons/text/CharacterPredicates.java --- @@ -48,5 +48,73 @@ public boolean test(int codePoint) { public

[GitHub] commons-text issue #51: TEXT-91: RandomStringGenerator should be able to gen...

2017-06-14 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/commons-text/pull/51 Looks good to me! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so

[GitHub] commons-fileupload issue #6: improve GC by avoiding FileInput/Output-Streams

2017-04-27 Thread jvz
Github user jvz commented on the issue: https://github.com/apache/commons-fileupload/pull/6 I don't see Oracle passing along that money to the ASF to continue maintaining Java 6 software, though. ;) --- If your project is set up for it, you can reply to this email and have