[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 hrm... or at least its not consistent. I just ran it twice more and failed only once. ∴mvn test -Dtest=TestGenericObjectPool#testCloseMultiplePools I'm not generall

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-20 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 The new test doesn't fail for me if I reverse the original change: ``` [INFO] --- [INFO] T E S T S

[GitHub] commons-pool issue #17: POOL-359: prevent NPE closing multiple GenericObject...

2018-11-18 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-pool/pull/17 Works for me. Blocked on INFRA-17267 travis fails for unrelated reasons, but tests pass locally: ``` [INFO

[GitHub] commons-collections issue #55: COLLECTIONS-697 JavaDoc FixedSizeList should ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-collections/pull/55 cool. Now we're waiting for INFRA-17094. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.or

[GitHub] commons-collections pull request #55: COLLECTIONS-697 JavaDoc FixedSizeList ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/55#discussion_r64747 --- Diff: src/main/java/org/apache/commons/collections4/list/FixedSizeList.java --- @@ -31,6 +31,12 @@ * The add, remove, clear and

[GitHub] commons-collections pull request #55: COLLECTIONS-697 JavaDoc FixedSizeList ...

2018-10-03 Thread grimreaper
Github user grimreaper commented on a diff in the pull request: https://github.com/apache/commons-collections/pull/55#discussion_r64719 --- Diff: src/test/java/org/apache/commons/collections4/list/FixedSizeListTest.java --- @@ -66,4 +68,20 @@ public String

[GitHub] commons-collections issue #48: global: make use of FunctionalInterface

2018-07-28 Thread grimreaper
Github user grimreaper commented on the issue: https://github.com/apache/commons-collections/pull/48 IMHO yes, though that should be done separately. --- - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org

[GitHub] commons-collections pull request #49: [SetUniqueList] avoid use of deprecate...

2018-07-27 Thread grimreaper
GitHub user grimreaper opened a pull request: https://github.com/apache/commons-collections/pull/49 [SetUniqueList] avoid use of deprecated newInstance You can merge this pull request into a Git repository by running: $ git pull https://github.com/grimreaper/commons

[GitHub] commons-collections pull request #48: global: make use of FunctionalInterfac...

2018-07-23 Thread grimreaper
GitHub user grimreaper opened a pull request: https://github.com/apache/commons-collections/pull/48 global: make use of FunctionalInterface Now that we're using Java 8, it seems reasonable to annotate. You can merge this pull request into a Git repository by running:

[GitHub] commons-collections pull request #47: IdentityMap: correct JavaDoc

2018-07-23 Thread grimreaper
GitHub user grimreaper opened a pull request: https://github.com/apache/commons-collections/pull/47 IdentityMap: correct JavaDoc You can merge this pull request into a Git repository by running: $ git pull https://github.com/grimreaper/commons-collections eax/jdoc/fixit

[GitHub] commons-collections pull request #46: travis: add java 10 to build

2018-07-23 Thread grimreaper
GitHub user grimreaper opened a pull request: https://github.com/apache/commons-collections/pull/46 travis: add java 10 to build You can merge this pull request into a Git repository by running: $ git pull https://github.com/grimreaper/commons-collections eax/java10/addcheck

[GitHub] commons-collections pull request #45: [COLLECTIONS-691] Use boolean operator...

2018-07-23 Thread grimreaper
GitHub user grimreaper opened a pull request: https://github.com/apache/commons-collections/pull/45 [COLLECTIONS-691] Use boolean operator for boolean result You can merge this pull request into a Git repository by running: $ git pull https://github.com/grimreaper/commons