Re: [LANG] Java 9 problems because of dependencies to java.desktop (Was: Re: [LANG] Thoughts about Lang 4.0)

2018-06-10 Thread Chas Honton
What’s the minimum target jre? If 8 or later, use java.util.BiConsumer. Otherwise, create a custom @FunctionalInterface. Chas > On Jun 10, 2018, at 2:52 PM, Bruno P. Kinoshita > wrote: > > Great catch indeed Gilles. > > > So perhaps just leave the deprecated, wit

Re: commons-csv git commit: CSV-216: Avoid Arrays.copyOf()

2018-02-16 Thread Chas Honton
Read Bloch. Don’t optimize until you have proven that this bit of code is causing a significant performance hit. arrayCopy can and is inlined by jit. Chas > On Feb 16, 2018, at 5:53 AM, Stian Soiland-Reyes wrote: > > String is still a type of Object (requiring GC handling of

Re: [text] Adapt the Log4j 2 Interpolator to [text]

2018-02-11 Thread Chas Honton
Definitely create interfaces. Chas > On Feb 11, 2018, at 1:57 PM, Gary Gregory wrote: > > On Sun, Feb 11, 2018 at 2:46 PM, Gary Gregory > wrote: > >> >> >> On Sun, Feb 11, 2018 at 12:05 PM, Pascal Schumacher < >> pascalschumac...@gmx.net> w

Re: Parent POM and automatic module name

2018-01-08 Thread Chas Honton
Profile triggers in src/profiles? Chas > On Jan 8, 2018, at 4:27 PM, sebb wrote: > >> On 8 January 2018 at 23:14, Jörg Schaible wrote: >> Am Mon, 08 Jan 2018 00:48:08 + schrieb sebb: >> >>> On 8 January 2018 at 00:25, Jörg Schaible wrote: >> &

Re: [parent] Release commons-parent 43

2018-01-02 Thread Chas Honton
+1 to Jorge ‘s comments Chas > On Jan 2, 2018, at 3:05 AM, sebb wrote: > > +1 > > Unlike components, there's no harm releasing CP as its usage is under > our control. > If it turns out there is a problem with CP 43, then we can just ignore it. > >>

Re: [lang] Add a DaemonThreadFactory

2017-12-21 Thread Chas Honton
I also have one of these. +1 Chas > On Dec 21, 2017, at 7:34 AM, Roger Whitcomb wrote: > > I have a class almost identical to this in my project, so +1 to this idea. > > ~Roger Whitcomb > > -Original Message- > From: Gary Gregory [mailto:garydgreg...@gma

Re: [build-plugin] Re-engineering/release streamlining

2017-11-11 Thread Chas Honton
Take a look at how the maven team votes and publishes Chas > On Nov 11, 2017, at 8:26 PM, Matt Benson wrote: > > On Nov 11, 2017 9:32 PM, "Rob Tompkins" wrote: > > > >>> On Nov 11, 2017, at 10:24 PM, Gary Gregory wrote: >>> >>&g

Re: [2/2] [lang] remove unused bcel test dependency

2017-10-15 Thread Chas Honton
You can use dependency:analyze to find used and undeclared or unused and declared dependencies. Perhaps we should add dependency:analyze-only to release profile of parent pom to make sure dependencies are clean. Chas > On Oct 14, 2017, at 9:56 AM, Gary Gregory wrote: > > boom! :-)

Re: [CANCEL][VOTE] Release Apache Commons IO 2.6 based on RC2

2017-10-15 Thread Chas Honton
Jacoco code coverage does runtime instrumentation, so this would not happen with Jacoco profile. Chas > On Oct 15, 2017, at 2:45 AM, Benedikt Ritter wrote: > > Hello, > >> Am 14.10.2017 um 14:35 schrieb Benedikt Ritter : >> >> Hello, >> >> we

Re: [ALL] Automated requirements (e.g. CheckStyle)?

2017-08-08 Thread Chas Honton
es. The more we automate, the less we need to remember and the higher the quality of our code. Chas > On Aug 8, 2017, at 4:13 PM, Gilles wrote: > > Hello. > >> On Wed, 9 Aug 2017 00:20:00 +0200, Karl-Philipp Richter wrote: >> Hi, >> >>> Am 07.08.2017 um 1

Re: [lang] - Close java.util.Date related enhancement requests as won't fix?

2017-04-19 Thread Chas Honton
+1 to close all Chas > On Apr 19, 2017, at 9:18 AM, Emmanuel Bourg wrote: > >> Le 19/04/2017 à 18:00, Pascal Schumacher a écrit : >> >> What do you think? > > I agree for LANG-1065, this case is covered by the Java 8 API. The > improvements suggested in the

Re: [text] On the value of idempotent string escape methods?

2017-02-21 Thread Chas Honton
Not sufficiently useful to include in commons. Chas > On Feb 21, 2017, at 1:31 PM, Bhowmik, Bindul wrote: > >> On Tue, Feb 21, 2017 at 7:55 AM, sebb wrote: >>> On 21 February 2017 at 12:40, Rob Tompkins wrote: >>> >>>> On Feb 21, 2017, at 6:02

Re: [ALL] hashes of signatures

2016-10-31 Thread Chas Honton
There was an update in parent to prevent excess jars from being attached as artifacts. https://svn.apache.org/viewvc/view=revision&revision=1755904 I don't believe it's been released. Chas > On Oct 31, 2016, at 9:53 AM, Matt Benson wrote: > > Thanks for repying,

Re: [VOTE] Release commons-parent 41 based on RC2

2016-08-10 Thread Chas Honton
No votes. Will work on release tonight. Chas > On Aug 10, 2016, at 9:27 AM, Gary Gregory wrote: > > Has this vote been tabulated? > > Gary > >> On Wed, Aug 3, 2016 at 9:17 PM, Charles Honton wrote: >> >> We have added a significant enhancements sin

Re: [ALL] Create a pom parent 41 release

2016-07-26 Thread Chas Honton
Unfortunately no. Report plugins cannot have dependencies changed. Chas > On Jul 25, 2016, at 10:06 PM, Gary Gregory wrote: > > Now that BCEL 6.0 is out, can the parent POM make Clirr use BCEL 6? > > Gary > >> On Mon, Jul 25, 2016 at 8:03 PM, Charles Honton wrote:

Re: [RESULT][VOTE] Release Apache Commons BCEL 6.0 based on RC8

2016-07-14 Thread Chas Honton
Congratulations! Chas > On Jul 14, 2016, at 12:42 AM, Benedikt Ritter wrote: > > This vote passes (am I dreaming? ;-) The following votes were cast: > > Oliver Heger: +1 (binding) > Gary Gregory: +1 (binding) > Mark Roberts: +1 > Oliver Lamy: +1 (binding) >

Re: [LANG] Failing tests

2016-05-01 Thread Chas Honton
sing maven 3.3.9 and Java 1.8.0_92. Chas > On May 1, 2016, at 12:20 PM, sebb wrote: > >> On 1 May 2016 at 19:32, Benedikt Ritter wrote: >> Hi, >> >> when building a clean checkout of Commons LANG, I get a lot of failing >> tests: > > OS? > Ja

Re: [math] Name of the new TLP

2016-01-25 Thread Chas Honton
. Chas > On Jan 25, 2016, at 9:21 PM, Henri Yandell wrote: > > Any reason why you're not going with Apache Math - math.apache.org? > > No one is going to wince if you have other language implementations in the > same project, and if it needs to break up over time because

Re: [lang] LANG-1192: FastDateFormat support of the week-year component (uppercase 'Y')

2015-12-17 Thread chas
Reverted pending investigation of travis failures chas Quoting Benedikt Ritter : -1 All Travis builds started failing after this commit [1] Benedikt [1] https://travis-ci.org/apache/commons-lang/builds 2015-12-14 1:39 GMT+01:00 : Repository: commons-lang Updated Branches: refs/heads

Re: svn commit: r1695425 - in /commons/proper/bcel/trunk/src/main/java/org/apache/commons/bcel6: generic/FieldOrMethod.java verifier/statics/Pass3aVerifier.java verifier/structurals/InstConstraintVisi

2015-09-09 Thread Chas Honton
Will work in this evening. (GMT-8). Chas > On Sep 9, 2015, at 2:07 AM, sebb wrote: > > PING > > I am -1 on the commit as it stands; please revert or fix > >> On 28 August 2015 at 01:43, sebb wrote: >>> On 12 August 2015 at 07:32, wrote: >>> Autho

[BCEL] InstructionHandle refactor

2015-08-24 Thread Chas Honton
I've created a pull request for a major refactor of how InstructionList and InstructionHandle work. Please review the contents of https://github.com/apache/commons-bcel/pull/2. Thanks, Chas - To unsubscribe, e-mail

Re: [VOTE] Release BCEL 6.0 based on RC4

2015-08-18 Thread chas
thread. Several contributors are working through the issues. More help is welcome! regards, chas - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional commands, e-mail: dev-h...@commons.apache.org

Re: [VOTE] Release BCEL 6.0 based on RC4

2015-08-10 Thread chas
For those asking for a CLIRR, I have created one base upon RC3: https://people.apache.org/~chas/bcel-6.0-RC3/clirr-report.html regards, chas - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For additional

[VOTE] Release BCEL 6.0 based on RC4

2015-08-09 Thread chas
/apache/commons/commons-bcel6/6.0/ Details of changes since 5.2 are in the release notes: https://dist.apache.org/repos/dist/dev/commons/bcel/RELEASE-NOTES.txt https://people.apache.org/~chas/bcel-6.0-RC4/changes-report.html I have tested this with JDK 1.7 using maven3. The tag is here

Re: [lang] LANG-1149 Ability to throw checked exceptions without declaring them

2015-07-24 Thread chas
Done. Quoting Benedikt Ritter : This line fails on Java 6, see https://travis-ci.org/apache/commons-lang/jobs/72455431#L1406 Can we fix this? Benedikt - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org For add

[BCEL] 6.0 RC4

2015-07-19 Thread chas
It is time to release BCEL-6.0, RC4. If there are no objections, I'll act as release manager. Since this is the first time I'll be taking this role, I appreciate your patience. regards, chas - To unsubscri

Re: [LANG] Time for 3.5?

2015-06-26 Thread Chas Honton
Benedikt, Please take a look at mr pull request for FastDateParser. Thanks, Chas > On Jun 26, 2015, at 4:19 AM, Benedikt Ritter wrote: > > Hi, > > we have a lot of good new stuff, so I'm planning to review pending issues > over the next weeks and push out the next re

[Lang] commons-lang pull request: refactor FastDateParser

2015-06-11 Thread Chas Honton
I just created a pull request for a major refactor of the FastDateParser class. I request anyone with org.apache.commons.lang3.time interest and/or experience take time to review. Thanks, Chas Begin forwarded message: > From: chonton > Date: June 11, 2015 at 8:19:46 PM PDT >

Re: [LANG] Build failing on Travis CI

2015-05-02 Thread chas
This does not seem to be a java 6 problem, as the Oracle JRE 6 for MacOSX works. I've updated to work with OpenJDK as well. chas Quoting Chas Honton : I will work on this weekend. Regards, Chas On May 1, 2015, at 3:07 AM, Benedikt Ritter wrote: Hello Charles, it looks like

Re: [LANG] Build failing on Travis CI

2015-05-01 Thread Chas Honton
I will work on this weekend. Regards, Chas > On May 1, 2015, at 3:07 AM, Benedikt Ritter wrote: > > Hello Charles, > > it looks like your latest fixes have caused a regression (but only on JDK > 6?!) [1]. Do you have time to have a look? Thank you so much for working on

Re: [lang] testTimeZoneStrategyPattern() runs twice for no apparent gain

2015-04-11 Thread Chas Honton
Duncan, Nothing lost by moving into separate test class. Speed gained. Chas > On Apr 11, 2015, at 12:02 AM, Duncan Jones wrote: > > Hi everyone, > > Lang takes a few minutes to build on my system, so I was examining > execution times of tests to see if anything can b

Re: svn commit: r1671734 - in /commons/proper/lang/trunk/src: changes/ main/java/org/apache/commons/lang3/time/ test/java/org/apache/commons/lang3/reflect/ test/java/org/apache/commons/lang3/time/

2015-04-07 Thread Chas Honton
Benedikt, Expletive, I wasn't being careful. The changes to FieldUtilsTest are to allow test to pass under jacoco coverage. I will revert, add another JIRA, fix changed.xml, and split into two commits tonight. Chas > On Apr 6, 2015, at 11:29 PM, Benedikt Ritter wrote: > >

Re: [VOTE] Release Apache Commons Lang 3.4 based on RC2

2015-04-04 Thread Chas Honton
I have changes which will get tests to pass. Any preference to whether they should be added to 3.4 or 3.5? Chas > On Apr 4, 2015, at 5:01 AM, Benedikt Ritter wrote: > > 2015-04-04 10:57 GMT+02:00 Duncan Jones : > >> +0 (non-binding) >> >> Built from zipped s