Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/64
@chtompki Closing this as we decided to remove it in 2.0. Thanks for the
input @PascalSchumacher !
---
-
To unsubscribe
Github user arunvinudss closed the pull request at:
https://github.com/apache/commons-text/pull/64
---
-
To unsubscribe, e-mail: dev-unsubscr...@commons.apache.org
For additional commands, e-mail: dev-h
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/64
@chtompki Yes Rob I would definitely vote in the affirmative. Since the
functionality provided by that method is trivial I would be surprised if anyone
was using it in the first place
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/64
Hey @PascalSchumacher! In my understanding we didn't make a decision yet. A
part of the reason is that it was exposed as a public method and since
consumers would potentially l
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/65
Hey @PascalSchumacher ! I looked at a couple of other commons projects but
seems like we don't have and/or follow a standard for pom files. Each have
their own way of listing t
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/65
Sort pom file
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunvinudss/commons-text sort-pom-file
Alternatively you can review and
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/64
Minor JavaDoc change for deprecated isDelimiter
@chtompki Please review and merge.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/57
@chtompki Please review and merge.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/57
@ameyjadiye I want to remove the isDelimiter method. I would be surprised
if someone uses isDelimiter separately because all it does is to check if a
given element is present in an array or
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/57
TEXT-98: Remove isDelimiter and use HashSets for delimiter checks
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunvinudss/commons
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
@ameyjadiye Done.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Okay I don't mind to change but what does UTF-16 with surrogate pairs
support? Why did we do this refactoring?
---
If your project is set up for it, you can reply to this email and
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Not sure why I should change the PR name? I never mentioned it provides
native support for UTF-32 and it clearly states support using surrogate pairs .
---
If your project is set up for it
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
Ordering of import has changed as all the similar packages were grouped
together. It was not intended I believe my IDE did that automatically. I see
other test classes using wild card
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@chtompki Updated with the changes you suggested .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/49
@ecki I agree and thats the best we can do for now to support UTF-32 .
Thanks for the input ð
---
If your project is set up for it, you can reply to this email and have your
reply
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/49
TEXT-89: UTF-32 support for WordUtils.initials
@chtompki Adding support for surrogate pairs to WordUtils.initials.
Characters outside BMP can be used now and also added unit tests for
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/48
@ameyjadiye The agreed upon fix as of now should be:
WordUtils.capitalizeFully("i am fine", new char[]{}) --> I am fine
We shouldn't take space as the del
Github user arunvinudss commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121417851
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user arunvinudss commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121408959
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user arunvinudss commented on a diff in the pull request:
https://github.com/apache/commons-text/pull/46#discussion_r121406140
--- Diff: src/main/java/org/apache/commons/text/CaseUtils.java ---
@@ -0,0 +1,140 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/47
@chtompki Added test cases to improve line coverage .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/47
Improved test coverage for StrTokenizer
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunvinudss/commons-text improveTestCoverage
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@sebbASF Nope the first letter is not capitalized and I expected the same
. It seems to happen if the specified delimiters are not available on the input
though .
---
If your project is
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@chtompki Just wondering why space is added as a default delimiter for null
delimiter arrays but not for empty delimiter array in WordUtils.capitalizeFully
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@chtompki The current implementation is based on these assumptions.
- All delimiters are stripped off .
- Space(32) is added as the default delimiter for all scenarios including
Github user arunvinudss commented on the issue:
https://github.com/apache/commons-text/pull/46
@chtompki Using HashSets for checking delimiters it reduces the time
complexity from O(nk) to O(n) . I feel it's more efficient .
---
If your project is set up for it, you can rep
GitHub user arunvinudss opened a pull request:
https://github.com/apache/commons-text/pull/46
TEXT-85:Added CaseUtils class with camel case conversion support
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/arunvinudss/commons
28 matches
Mail list logo
