Re: [Math] Low-discrepancy sequences

2021-06-07 Thread Samy Badjoudj
Hello Gilles, Is there something we  need to change https://github.com/apache/commons-math/pull/190, that one comes after the discussion we had. Thanks On 01.06.21 20:42, Samy Badjoudj wrote: On 01.06.21 20:02, Gilles Sadowski wrote: Le mar. 1 juin 2021 à 15:25, Samy Badjoudj a écrit

Re: [Math] Low-discrepancy sequences

2021-06-01 Thread Samy Badjoudj
On 01.06.21 20:02, Gilles Sadowski wrote: Le mar. 1 juin 2021 à 15:25, Samy Badjoudj a écrit : Thanks Gilles, please find below my remarks On 01.06.21 12:37, Gilles Sadowski wrote: Le lun. 31 mai 2021 à 02:07, Gilles Sadowski a écrit : Hello. Halton and Sobol sequences have been

Re: [Math] Low-discrepancy sequences

2021-06-01 Thread Samy Badjoudj
Thanks Gilles, please find below my remarks On 01.06.21 12:37, Gilles Sadowski wrote: Le lun. 31 mai 2021 à 02:07, Gilles Sadowski a écrit : Hello. Halton and Sobol sequences have been implemented in the "random" package. From Wikipedia[1]: ---CUT--- Low-discrepancy sequences are also calle

[MATH] (MATH-1597) Low-discrepancy sequence

2021-05-31 Thread Samy Badjoudj
Hi Gilles, Following up the discussion on https://issues.apache.org/jira/browse/MATH-1597 * My suggestion was for "skip" to be similar to "jump" (i.e. it would return a "SkippableSequence")... * Yes will improve the API design. I tried it by returning the LowerDiscrepencySequence so we do not e

[Math][Request for review] MATH-1592

2021-05-30 Thread Samy Badjoudj
Hi, As part of modularization coming, https://issues.apache.org/jira/browse/MATH-1592 https://github.com/apache/commons-math/pull/186 The idea there, is that TransformerMap in descriptive statistics, will not be part of the api anymore for a clear separation of concerns. Caller will perform

[Math][Request for review] MATH-1468

2021-05-30 Thread Samy Badjoudj
Hi, As part of modularization coming, https://issues.apache.org/jira/browse/MATH-1468 https://github.com/apache/commons-math/pull/185 Decimal64 and Decimal64Field should not be part of the public API, and go along with the tests they are us in. Thanks Kind regards ---

[Math][Request for review] MATH-1586

2021-05-27 Thread Samy Badjoudj
Hi, Following up on modularization of apache commons maths. https://issues.apache.org/jira/browse/MATH-1586 with https://github.com/apache/commons-math/pull/182. I moved the classes  from org.apache.commons.math4.legacy.util to packages where they are used exclusively (stat,linear). Should