Re: [compress] 7z and Recovering Corrupt Archives

2021-06-06 Thread Peter Lee
+1 for the new option. A fast fail for corrupted archive could help a lot. Lee On 6 5 2021, at 4:32, Gary Gregory wrote: > In general, I think fail fast is ok with a clear exception message. > > Gary > On Fri, Jun 4, 2021, 15:44 Stefan Bodewig wrote: > > Hi all > > > > 7z archives provide CRCs f

Re: [all] OSS Fuzz

2021-04-22 Thread Peter Lee
Hi Fabian, Thanks a lot for all this. > One more thing: Could you perhaps add the following line to the READMEs of > compress and imaging? > I just created a PR in Compress https://github.com/apache/commons-compress/pull/189 Seems I missed a lot these days. :-( I also got a Google account(pete

Re: [all] OSS Fuzz

2021-04-15 Thread Peter Lee
+1 to fuzz. Fuzzing is widely used in many open source projects and it helped a lot in Compress. For the mailing list, many projects use Security. And creating a new one is OK for me. > I'd add myself as a moderator but we will need more moderators. If we need moderators, count me in. cheers, Le

Re: [COMPRESS] OSS-Fuzz integration

2021-03-07 Thread Peter Lee
I think the security list is a good choice. Lee On 3 8 2021, at 2:55, Stefan Bodewig wrote: > On 2021-03-07, Gary Gregory wrote: > > > This issue has popped as well WRT GitHub emails from Dependabot. > I don't think this is comparable. > The fuzzer may find issues that can be exploited as DoS att

[COMPRESS] Naming of a new option in Zip64Mode

2021-02-28 Thread Peter Lee
Hi, all. Recently there was a issue COMPRESS-565 about the Zip64. And I have pushed a fix PR #169 for it. The fix introduces a new option in Zip64Mode, which is a compromise solution for 7z, Expand-Archive and likely Excel. I named the new option `AlwaysWithCompatibility`, which may not be a goo

Re: [All][Math] GH PR and Travis-CI

2020-12-22 Thread Peter Lee
> but the build result is not shown in github. Correction : the build result is shown in github. I missed it cause the tab was hidden. :( Seems the travis build is triggered 10 hours later than the commit was submitted. cheers, Lee On 12 22 2020, at 7:50, Peter Lee wrote: > It's

Re: [All][Math] GH PR and Travis-CI

2020-12-22 Thread Peter Lee
It's weird cause travis seems have a successful build with this PR: https://travis-ci.com/github/apache/commons-math/builds/210145524 but the build result is not shown in github. Maybe it's just a accidental error and we can have a look till next PR? cheers, Lee On 12 21 2020, at 11:31, Gilles Sa

Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-17 Thread Peter Lee
gt; not have to pay the price for a feature they don't want. Think of an app > that looks at large tar... > > Gary > On Sun, Nov 15, 2020, 21:51 Peter Lee wrote: > > Hi all, > > > > Robin has pushed a PR in github in July that implemented the random access > >

Re: [Compress] COMPRESS-540 : Random access of tar

2020-11-15 Thread Peter Lee
PR. > No blockers for me. Hope it helps. > Thanks for bringing it to the mailing list, and for the review. > CheersBruno > > On Monday, 16 November 2020, 3:51:48 pm NZDT, Peter Lee > wrote: > Hi all, > Robin has pushed a PR in github in July that implemented the random

[Compress] COMPRESS-540 : Random access of tar

2020-11-15 Thread Peter Lee
Hi all, Robin has pushed a PR in github in July that implemented the random access of tar : https://github.com/apache/commons-compress/pull/113 It's achieved by reading the tar once and have the start position of each tar entry stored. Tar is not designed to be random accessed so this may be a t

Re: [COMPRESS] Pack200 support in pack200 branch

2020-11-02 Thread Peter Lee
: > > > >> Thanks Peter, I updated the branch and the build passes for me locally, > >> the CI is building now here > >> https://github.com/apache/commons-compress/actions/runs/19115 > >> > >> Gary > >> > >&g

Re: [compress] BZip2CompressorInputStream stops working without rhyme or reason ...

2020-10-16 Thread Peter Lee
Hi Albretch, This seems to be more suitable to be discussed in JIRA : https://issues.apache.org/jira/projects/COMPRESS/issues (https://link.getmailspring.com/link/1994dde5-ebdc-4f24-9bc7-105cf6551...@getmailspring.com/0?redirect=https%3A%2F%2Fissues.apache.org%2Fjira%2Fprojects%2FCOMPRESS%2Fissue

Re: [All] About Commons snapshot versions

2020-09-09 Thread Peter Lee
were set up to do so. A > migration to a new build system just took place and I don't know if we have > Commons builds on the new CI system yet. > > Gary > On Wed, Sep 9, 2020, 22:18 Peter Lee wrote: > > Hi all, > > > > I noticed that some Commons components snapshot v

[All] About Commons snapshot versions

2020-09-09 Thread Peter Lee
Hi all, I noticed that some Commons components snapshot versions released in https://repository.apache.org/content/groups/snapshots/org/apache/commons have not been updated for some time. Just curious about how do we publish snapshot versions and how often do we do that? cheers, Lee

Re: [COMPRESS] Pack200 support in pack200 branch

2020-08-23 Thread Peter Lee
After some debugging I found this at org.apache.harmony.pack200.Archive#171 : if (classes.size() > 0 && files.size() > 0) { segmentUnitList.add(new SegmentUnit(classes, files)); } Seems the Pack200 implementation in harmony requires existing of both classes AND files at the same time. The tests a

Re: [Compress] Build failure in jenkins and github actions

2020-08-22 Thread Peter Lee
hY2hlLm9yZw%3D%3D) cheers, Lee On 8 21 2020, at 10:18 , Gary Gregory wrote: > On Thu, Aug 20, 2020 at 7:57 AM Peter Lee wrote: > > > Hi all, > > > > The builds in jenkins and github actions are failing. > > For jenkins, the java7, 14 and 16 builds are failing. As we h

Re: [Compress] Build failure in jenkins and github actions

2020-08-21 Thread Peter Lee
the Pac200 from jdk and create a new lib for it, and we invoke > > that lib instead of jdk's Pac200. > > 3. we clean room a implementation of Pac200 (seems not quite worthy) > > > > So which will we pick? > > Or, any better ideas? > > > > Pe

Re: [Compress] Build failure in jenkins and github actions

2020-08-21 Thread Peter Lee
;m just thinking if we should make the builds' status green on JDK14+ by setting some "allow failure" config in GH actions and jenkins. cheers, Lee On 8 20 2020, at 8:06 , Gary Gregory wrote: > On Thu, Aug 20, 2020 at 7:57 AM Peter Lee wrote: > > > Hi all, > >

[Compress] Build failure in jenkins and github actions

2020-08-20 Thread Peter Lee
Hi all, The builds in jenkins and github actions are failing. For jenkins, the java7, 14 and 16 builds are failing. As we have moved from JAVA 7 to 8, maybe we should disable java 7 build in jenkins? Besides the java 14 and 16 are also failing, and we can have some "allow failure" config on them

Re: [COMPRESS] Java 7- > 8

2020-08-12 Thread Peter Lee
+1 for this. But it is not because of the lambdas(personally I do like the lambdas, but it is not a reason that could convince me to update the JDK). The OpenJDK7 is not supported basing on OpenJDK life cycle police any more recently(EOS since June, 2020) - and this is why I think should update

Re: [commons-compress] branch master updated: Enable GitHub Dependabot.

2020-07-26 Thread Peter Lee
It's why apache and open source is so charming and why we all love this so much. :-) cheers, Lee On 7 26 2020, at 10:04 , Rob Tompkins wrote: > > > > On Jul 26, 2020, at 9:53 AM, Peter Lee wrote: > > > > Hi Stefan, Rob, Gilles, Gary and all, > > > >

Re: [commons-compress] branch master updated: Enable GitHub Dependabot.

2020-07-26 Thread Peter Lee
Hi Stefan, Rob, Gilles, Gary and all, Please calm. I was just talking that I'm so busy recently ( Too busy in the daytime that I got home after 12p.m. these days :( ) .I didn't check my mailbox after my last replay in this thread. Really sorry for my late reply. I'm not complaining. I personally

Re: [commons-compress] branch master updated: Enable GitHub Dependabot.

2020-07-23 Thread Peter Lee
Got plenty of mails this morning(which surprised me a lot). Seems they are all triggered by github dependency bot. Have been too busy these days. Will try to look into them this weekend. On 7. 23 2020, at 5:12 , Gilles Sadowski wrote: > Hi. > > 2020-07-22 18:32 UTC+02:00, Stefan Bodewig : > > I h

[VFS] VFS-748 : about files cache

2020-06-28 Thread Peter Lee
Hi all, As the issue VFS-748 said, it seems there's a problem in TarFileSystem about the files cache : it will be removed after a JVM gc. I looked into the code and found out that the cache is held by the local variable strongRef : the variable strongRef and the variable fileObj are holding each

[Compress] COMPRESS-538 : about Zip64

2020-06-27 Thread Peter Lee
Hi all, The recent issue COMPRESS-538 talks about the zip64 extra field in Local File Header. Currently we will add a Zip64 extra field for the entries with uncompressed size unspecified. And we will update the zip64 extra field in ZipArchiveOutputStream.rewriteSizesAndCrc a little bit : if we ac

Re: About binary compatibility

2020-06-15 Thread Peter Lee
> I kind of like inaging1 even if it is weird and even though we do not have a > precedent here in Commons. I'm curious what others think. I think you are meaning imaging1 instead of inaging1 :) Indeed imaging1 is kind of weird but looks good to me. +1 On June, 16, 2020, at 7:06 , Gary Gregory

[VFS] A wildcard scheme for archives

2020-06-06 Thread Peter Lee
Hi all, The Commons Compress has the capality to provide many archive/compress types(zip, 7z, zstd, lz4 ...). I'm thinking about if we could provide a wildcard scheme for archives/compressors using Compress as the provider. WDYT? BTW : I can not connect to the Apache SMTP server(a.k.a mail-rely.a

Re: [commons-compress] branch master updated: minor typos cleanup

2020-06-01 Thread Peter Lee
Oops, I was looking the commit and found two @throws IllegalArgumentException, and I was thinking this is a duplicated throws caused by copy-paste. And I was so much foolish that I deleted it without any invesgating into the code. Really sorry about this. On Mon, Jun 1, 2020 at 10:57 PM Stefan Bod

Re: [commons-compress] branch master updated: COMPRESS-530 : skip non-number when parsing pax header

2020-05-27 Thread Peter Lee
Did some googles, can't find too much but this : https://www.systutorials.com/docs/linux/man/5-star/ And it says : > Each record starts with a a decimal length field. The length includes the total size of a record including the length field itself and the trailing new line. Seems we should throw a

Re: [commons-compress] branch master updated: COMPRESS-529 : throws IOException if non-number exists in pax header

2020-05-27 Thread Peter Lee
when we are trying to read it as a double. I'll find out a proper way to throw the detailed exception without breaking the compatibility. On Wed, May 27, 2020 at 9:15 PM Stefan Bodewig wrote: > On 2020-05-27, Peter Lee wrote: > > > Oops, sorry about that. > > No big deal.

Re: [commons-compress] branch master updated: COMPRESS-529 : throws IOException if non-number exists in pax header

2020-05-27 Thread Peter Lee
Oops, sorry about that. Will undo all the commits. On Tue, May 26, 2020 at 11:50 PM Stefan Bodewig wrote: > On 2020-05-26, wrote: > > > -public void addPaxHeader(String name,String value) { > > - processPaxHeader(name,value); > > +public void addPaxHeader(String name, String val

Re: [COMPRESS] Travis build fail with JDK14

2020-05-13 Thread Peter Lee
pache/commons-vfs/commit/249d1dc9fb3f2bd5209aaa299c4ed61414f1fd78#diff-354f30a63fb0907d4ad57269548329e3 > > > > > > adding a unpassable check in travis will makes all pull requests/commit > > return builld failure, which will hide problem and make checker's life > hard. > > > > Ste

[COMPRESS] Travis build fail with JDK14

2020-05-13 Thread Peter Lee
Hi,all The travis build of Compress is failing now cause the openjdk14 was added to travis.yml recently. The reason is the Pack200 was removed from JDK14 and there was a discussion about it in January. Emmanuel is working on his replacement project(https://github.com/pack200/pack200) but not fini

Re: [Compress]Add some easy-to-use APIs for Zip and other archivers

2020-03-10 Thread Peter Lee
> Peter, > > Please also take a look at Apache Commons VFS. Sure. I will look into Commons VFS. Thank you for your suggestion.

Re: [Compress]Add some easy-to-use APIs for Zip and other archivers

2020-03-10 Thread Peter Lee
Just finished reading the COMPRESS-118 and the 2 threads. I have to say that's a lot of content. :) I have also read the Archiver and the Expander, and I do like them a lot. They have great abstraction, and the implementation for callback(CloseableConsumer and Finisher) do impressed me. In the th

[Compress]Add some easy-to-use APIs for Zip and other archivers

2020-03-09 Thread Peter Lee
Hi all. I'm thinking about adding some easy-to-use APIs for Zip. Currently I got some ideas : 1. Add extractAll(String targetPath) in ZipFile : extract all the files to the specific directory. 2. Add getInputStream(String fileName) in ZipFile : get the input stream for a file by name. And I belie

Re: [Compress] Zip Files: History, Explanation and Implementation

2020-03-09 Thread Peter Lee
;m just hoping I can implement a fast deflater. Maybe the incubating VectorAPI may help me. It can achieve SIMD in native Java. Looks good. Stefan Bodewig 于2020年3月7日周六 下午11:13写道: > On 2020-03-07, Peter Lee wrote: > > > I'm planning to build a pure Java deflater/inflater on my own

Re: [Compress] Zip Files: History, Explanation and Implementation

2020-03-06 Thread Peter Lee
Great article. This may help a lot when learning about zip. I'm planning to build a pure Java deflater/inflater on my own. Believe this may help a lot. Gary Gregory 于2020年3月7日周六 上午10:30写道: > Just FYI:Zip Files: History, Explanation and Implementation > https://www.hanshq.net/zip.html > > Gary >

[Compress]Discussion about COMPRESS-499

2019-12-18 Thread Peter Lee
Hi all. A recent issue COMPRESS-499( https://issues.apache.org/jira/projects/COMPRESS/issues/COMPRESS-499) discussed about a potential problem in SeekableInMemoryByteChannel. Based on the java docs( https://docs.oracle.com/en/java/javase/11/docs/api/java.base/java/nio/channels/SeekableByteChannel.

Re: [Compress]New PRs on github need reviews

2019-11-26 Thread Peter Lee
comments/questions to the PR for Tar. > > cheers, > Torsten > > On Tue, Nov 26, 2019 at 4:46 AM Peter Lee > wrote: > > > Hi all, > > > > I'm Lee and I'm new to commons-compress. I'm a amateur in compression > > algorithms. I like common

[Compress]New PRs on github need reviews

2019-11-25 Thread Peter Lee
Hi all, I'm Lee and I'm new to commons-compress. I'm a amateur in compression algorithms. I like commons-compress cause it supports so many specifications. I'd like to contribute to it. Recently I pushed 3 PRs in github : 1. Add support for Tar with sparse entries 2. the split/spanned zip support