Re: svn commit: r1360580 - /commons/sandbox/graph/trunk/src/main/java/org/apache/commons/graph/model/BaseGraph.java

hi simo 2012/7/12 Simone Tripodi : > good! IMHO this can be fixed using the > org.apache.commons.graph.utils.Objects#hash() shortcut, i.e. yep... I just fixed it :P ciao - To unsubscribe, e-mail: dev-unsubscr...@commons.apache.

[Graph] Synchronyzed graph is not serializable

syncronized graph we could implement the syncronization in the same way of the java Collections. Otherwise we can annotate the CommonsGraph.syncronze method as not syncronyzed. WDYT? ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ signature.asc Description

Re: [graph][discuss] reintegrating branch in trunk

Hi, we could merge the branch and open some issues on Jira to track the exporter problems, so people can contribute to fix them. ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ 2012/3/23 Simone Tripodi : > Hi all guys, > > in order to speedup th

Re: [Graph] Test problems after last commit

d, but I didn't understand very well your idea. What does it means implement an adapter? Ciao ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 03/mar/2012, alle ore 17:24, Simone Tripodi ha scritto: > Hi again Marco, > > I though once a

Re: [Graph] Test problems after last commit

Ciao sorry I didn't understand very well. How could help a read/write lock? bye -- Marco Speranza Flickr: http://www.flickr.com/photos/marcosperanza79/ Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 03/mar/2012, alle ore 14:40, James Carman ha scritto: > I thin

Re: [Graph] Test problems after last commit

Sure that we can, the only issue we have is that GroboUtils is not in > the central repo, adding the external repository would make not easy > having the component released. unfortunately GroboUtil was the only lib that I found yesterday. Any suggestions to some other libs? all the best ;-)

Re: [Graph] Test problems after last commit

only one question. I think that we should add some tests in order to check the correct implementation of our multithrading implementation. Do you think that we can use an external library in test scope? have a nice day -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/

Re: [Graph] Test problems after last commit

Hi I fixed the problem using proxy/handler. I put also a couple of tests. For do that I insert a test scoped dependency to a library net.sourceforge.groboutils.groboutils-core Ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 03/mar/2012, alle ore 01:29

Re: [Graph] Test problems after last commit

I think that we have to use the same patter of java Collections: a wrapper of Graph/MutableGraph that use a synchronize block. WDYT? -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 03/mar/2012, alle ore 01:10, Simone Tripodi ha scritto: > OK now sou

Re: [Graph] Test problems after last commit

synchronizedMethods, args ); } } catch ( InvocationTargetException e ) { throw e.getTargetException(); } } return method.invoke( synchronizedMethods, args ); } ===

Re: [Graph] Test problems after last commit

's the best solution. WDYT? -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 02/mar/2012, alle ore 23:07, Simone Tripodi ha scritto: > uhm I am not really satisfied, the checks and the proxy handler > decrease performances, that is why I asked y

Re: [Graph] Test problems after last commit

Om perfect simo... I just checked it out.. great work. :-) -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 02/mar/2012, alle ore 22:36, Simone Tripodi ha scritto: > I would have preferred a Concurrent* version for our data structures, > but I can h

Re: [Graph] Test problems after last commit

I meant just what. I think that this patter is the best choice. > if yes, why should it be put in a separated class? the existing entry > point sounds be more than enough for hosting that methods. you are right so if you agreed I can work on that. Ciao -- Marco Speranza Google Code:

Re: [Graph] Test problems after last commit

. So the user can choose the preferred implementation. I'm working on a patch. If you agree I can create a patch to explain my idea. ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 02/mar/2012, alle ore 20:11, Simone Tripodi ha scritto: > wh

Re: [Graph] Test problems after last commit

. If you agree I can commit as soon as possible my idea? WDYT? -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 02/mar/2012, alle ore 19:32, Simone Tripodi ha scritto: > yes, same here, not only is stuck but consumes a lot of memory, > freezing the lap

[Graph] Test problems after last commit

Hi all, I run the test suite but after the latest commit it seems that the test org.apache.commons.graph.coloring.GraphColoringBackTrackingTestCase was frozen. Did you have the same problem? ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79

Re: [graph] Kosaraju's SCC algorithm

great work :-) -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 01/mar/2012, alle ore 21:26, Thomas Neidhart ha scritto: > Hi, > > I have checked in my version of Kosaraju's strongly connected components > algorithm. It is a first version an

Re: [graph] Doubts on DFS algorithm implementation

Ok great! now works thanks you! -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 01/mar/2012, alle ore 19:32, Thomas Neidhart ha scritto: > On 03/01/2012 07:06 PM, Marco Speranza wrote: >> Hi Thomas, >> >> I run the test and it seems

Re: [graph] Doubts on DFS algorithm implementation

x <-> y() is already present in the Graph Tests run: 109, Failures: 0, Errors: 1, Skipped: 0 I think that we have to add also a list of the visited edges to avoid that. Do you agree with me? Ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 01

Re: [graph] Doubts on DFS algorithm implementation

e SANDBOX-353 I think that we can put there our doubts on the implementation. hav a nice day -- Marco Speranza Flickr: http://www.flickr.com/photos/marcosperanza79/ Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 01/mar/2012, alle ore 08:59, Thomas Neidhart ha scritto: >

Re: [graph] Doubts on DFS algorithm implementation

e a nice day -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 29/feb/2012, alle ore 23:58, Thomas Neidhart ha scritto: > On 02/29/2012 11:07 PM, Marco Speranza wrote: >> Cool good job... >> >> Only one think.. I ran the tests and I exper

Re: [graph] Doubts on DFS algorithm implementation

ed: 1 [INFO] [INFO] BUILD FAILURE [INFO] the Edmonds and Karp algo uses the Breadth First Search, maybe there are some problem in bsf visit. ciao -- Marco Speranza

Re: [graph] Doubts on DFS algorithm implementation

visit also the edge in depth, (only in a dfs of course) or remove the invocation of discover/finish edge that can get confused the user. have a nice day -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 26/feb/2012, alle ore 23:41, Claudio Squarcella ha scrit

Re: [graph] Doubts on DFS algorithm implementation

nicer with that change in > mind (looks good to me). > +1 have a nice day guys ;) -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 25/feb/2012, alle ore 20:35, Claudio Squarcella ha scritto: > Hi, > > On 25/02/2012 19:51, James Carman

[graph] Doubts on DFS algorithm implementation

coverEdge( v, e, w ) ) { [ ... ] I think that the algo explores the edge, and than fires handler.discoverEdge( v, e, w ), in breadth and not in depth, doesn't it? best regards -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ signature.asc Description: Mess

Re: svn commit: r1291064 - in /commons/sandbox/graph/trunk/src: changes/ main/java/org/apache/commons/graph/ main/java/org/apache/commons/graph/connectivity/ main/java/org/apache/commons/graph/model/

fixed. Thanks for suggestion :) have a nice day -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 20/feb/2012, alle ore 00:31, Konstantin Kolinko ha scritto: >>> Author: marcosperanza >>> Date: Sun Feb 19 21:26:12 2012 >>> New Rev

Re: svn commit: r1291064 - in /commons/sandbox/graph/trunk/src: changes/ main/java/org/apache/commons/graph/ main/java/org/apache/commons/graph/connectivity/ main/java/org/apache/commons/graph/model/

Hi Simo, You are right. I changed the jira issue adding the same message writen into the change.xml file ciao -- Marco Speranza Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 19/feb/2012, alle ore 22:33, Simone Tripodi ha scritto: > Hi Marco, > svn log log messa

Re: [graph] renaming weight operations

Hi Claudio, > I will soon work on it. If there is any last minute suggestion I will be > happy to hear that. there isn't any suggestion by me... in my point of view your suggestion can be useful and increase the code expressiveness. have a nice day :) -- Marco Speranza Google

Re: svn commit: r1245786 - in /commons/sandbox/graph/trunk/src: main/java/org/apache/commons/graph/spanning/ test/java/org/apache/commons/graph/spanning/

ithm to apply - that > would be a nice addition IMHO, feel free to fill an issue and assign > to yourself if you want to add it (hint: > Preconditions.checkArgument()...) +1 I agree, this check can be useful thanks a lot for your suggestions all the best :-) -- Marco Spera

Re: [Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

rtexPair for retrieve the edge, so if the user passes an incorrect vertex the method doesn't throw an Excepion but simply returns a null reference to the user. Is it necessary to throw the same exception also for that method? thanks ;) -- Marco Speranza Flickr: http://www.flic

[Graph] Possible NPE if user requests a vertex that not exists on BaseGraph class

accepts the argument but return a null value to the user. Should it be a good idea put a control and throw a IllegalArgumentEx in both cases? WDYT? Ciao -- Marco Speranza apache.org> Google Code: http://code.google.com/u/marco.speranza79/

Re: svn commit: r1244252 - in /commons/sandbox/graph/trunk: ./ src/main/java/org/apache/commons/graph/shortestpath/ src/test/java/org/apache/commons/graph/flow/ src/test/java/org/apache/commons/graph/

t the NPE is thown from the method under test. Thanks for suggestion Ciao -- Marco Speranza apache.org> Google Code: http://code.google.com/u/marco.speranza79/ 2012/2/15 sebb > On 14 February 2012 22:42, wrote: > > Author: marcosperanza > > Date: Tue Feb 14 22:42:19 2012 &g

Re: [Graph] On graph weight type(s)

fault constructor using our mapper. so for the primitives Integer, Double etc, the user doesn't have to specify anything. for a graph that uses a custom weight's type, the user can use the findMaxFlow( graph ).from( a ).to( g ).applying( OrderMonoid ) ) API. WDYT ? ciao -- M

Re: [Graph] On graph weight type(s)

or something like that. Ciao -- Marco Speranza Flickr: http://www.flickr.com/photos/marcosperanza79/ Google Code: http://code.google.com/u/marco.speranza79/ Il giorno 11/feb/2012, alle ore 21:19, Simone Tripodi ha scritto: > Ciao Claudio! > > I understand and agree with you abo

[Graph] Burovka's algorithm implementation

le for comments and improvments :-) ciao Marco -- Marco Speranza Flick photostream: http://www.flickr.com/photos/marcosperanza79/ Google Code: http://code.google.com/u/marco.speranza79/

Re: [Graph] Graph connectivity algo

Il giorno 30/gen/2012, alle ore 15:33, Claudio Squarcella ha scritto: > > > On 30/01/2012 09:51, Marco Speranza wrote: >> Claudio Squarcella dia.uniroma3.it> writes: >> >>> >>> On 27/01/2012 12:47, Claudio Squarcella wrote: >>>> Hello

[Graph] Kruskal's algorithm doesn't accept sparse graph

ractQueue.java:90) at org.apache.commons.graph.spanning.DefaultSpanningTreeAlgorithmSelector.applyingKruskalAlgorithm(DefaultSpanningTreeAlgorithmSelector.java:87) I created a issue into Jira (SANDBOX-374) and I attached a patch that resolves the problem. heve a nice day :) -- Marco Speranza Flickr:

Re: [Graph] Graph connectivity algo

Claudio Squarcella dia.uniroma3.it> writes: > > > On 27/01/2012 12:47, Claudio Squarcella wrote: > > Hello, > > > > On 27/01/2012 12:35, Marco Speranza wrote: > >> Hi all, > >> > >> I'm trying to implement the Boruvka's algor

[Graph] Graph connectivity algo

e number of the vertices touched are the same of the origina graph, the graph is connected. Moreover the algorithm could count the number of che "connected componet" ( http://en.wikipedia.org/wiki/Connected_component_(graph_theory). what do you think about that? Ciao -- Marco Speranza

[graph] SANDBOX-332 Implementation of Floyd Warshall algo

Hi all, I'm new in this ML. I'd like to contribute to Graph Project with a little patch. It's an implemetnation of Floyd Warshall Algorithm. I just uploaded my patch into JIRA (#SANDBOX-332) Looking forward your comments and improvment Cheers -- Marco Speranza